Noosfero/noosfero

View on GitHub
app/models/user.rb

Summary

Maintainability
C
1 day
Test Coverage

Class User has 48 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < ApplicationRecord
  include Noosfero::Plugin::HotSpot
  include MetadataScopes
  include Notifiable

Severity: Minor
Found in app/models/user.rb - About 6 hrs to fix

    File user.rb has 387 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "digest/sha1"
    require "securerandom"
    
    # User models the system users, and is generated by the acts_as_authenticated
    # Rails generator.
    Severity: Minor
    Found in app/models/user.rb - About 5 hrs to fix

      Method activate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def activate(code)
          return unless code && short_activation_code
      
          if code.downcase == short_activation_code.downcase
            if environment.enabled?("admin_must_approve_new_users")
      Severity: Minor
      Found in app/models/user.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status