Noosfero/noosfero

View on GitHub
plugins/delivery/lib/delivery_plugin/display_helper.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method supplier_delivery_options has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def supplier_delivery_options(options = {})
    selected = options[:selected]
    methods = options[:methods] || profile.delivery_methods

    options = methods.map do |method|
Severity: Minor
Found in plugins/delivery/lib/delivery_plugin/display_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method button_to_function has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def button_to_function(type, label, js_code, html_options = {}, &block)
Severity: Minor
Found in plugins/delivery/lib/delivery_plugin/display_helper.rb - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status