Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/html5_video/lib/video_processor/ffmpeg.rb

Summary

Maintainability
D
3 days
Test Coverage

File ffmpeg.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "rmagick"
require "yaml"

# Works for ffmpeg version 2.8.6-1~bpo8 shiped by Debian Jessie Backports
# https://packages.debian.org/jessie-backports/ffmpeg
Severity: Minor
Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 3 hrs to fix

    Class Ffmpeg has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class VideoProcessor::Ffmpeg
  def _(str)
    str
  end
    Severity: Minor
    Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 2 hrs to fix

      Method run has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def run(*parameters)
    parameters = ([:threads, config["num_of_threads"]] + parameters).flatten
    cmd = ["ffmpeg"] + parameters.map do |p|
      p.kind_of?(Symbol) ? "-" + p.to_s : p.to_s
    end
      Severity: Minor
      Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run(*parameters)
    parameters = ([:threads, config["num_of_threads"]] + parameters).flatten
    cmd = ["ffmpeg"] + parameters.map do |p|
      p.kind_of?(Symbol) ? "-" + p.to_s : p.to_s
    end
      Severity: Minor
      Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 1 hr to fix

        Method video_thumbnail has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def video_thumbnail(video)
    result_dir = webdir_for_original_video video
    info = get_video_info(video)
    if info[:duration] < 15
      pos = 1
        Severity: Minor
        Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 1 hr to fix

          Method register_information has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def register_information
    response = self.run(:formats)[:output]
    @@version = /^\s*FFmpeg version ([0-9.]+)/i.match(response)[1]
    @@formats = {}
    response.split("--")[-1].strip.split("\n").each do |line|
          Severity: Minor
          Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 1 hr to fix

            Method get_video_info has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def get_video_info(file)
    response = self.run :i, file
    if response[:error][:code] == 2
      # No output is not an error on this context
      response[:error][:code] = 0
            Severity: Minor
            Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 1 hr to fix

              Method video_thumbnail has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def video_thumbnail(video)
    result_dir = webdir_for_original_video video
    info = get_video_info(video)
    if info[:duration] < 15
      pos = 1
              Severity: Minor
              Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method register_information has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def register_information
    response = self.run(:formats)[:output]
    @@version = /^\s*FFmpeg version ([0-9.]+)/i.match(response)[1]
    @@formats = {}
    response.split("--")[-1].strip.split("\n").each do |line|
              Severity: Minor
              Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method validate_conversion_conf_for_web has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def validate_conversion_conf_for_web(conf, file_type)
    conf = conf.clone
    if conf[:abrate].nil? || conf[:vbrate].nil? || conf[:size].nil?
      info = get_video_info(conf[:in])
      if info[:error][:code] == 0
              Severity: Minor
              Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method valid_vbrate_for_web has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def valid_vbrate_for_web(info)
    if brate = info.video_stream[0][:bitrate] || info[:global_bitrate]
      brate = 128 if brate < 128
      (brate > 1024) ? 1024 : brate
    else
              Severity: Minor
              Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method valid_abrate_for_web has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def valid_abrate_for_web(info)
    return 0 if info.audio_stream.empty?

    if brate = info.audio_stream[0][:bitrate]
      brate = 8 if brate < 8
              Severity: Minor
              Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_stream_info has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def get_stream_info(stream_str)
    stream_info = { type: "undefined" }
    stream_info[:type] = "video" if / Video:/.match(stream_str)
    stream_info[:type] = "audio" if / Audio:/.match(stream_str)
    {
              Severity: Minor
              Found in plugins/html5_video/lib/video_processor/ffmpeg.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def convert2ogv(conf)
    conf[:type] = :OGV
    conf[:vbrate] ||= 600
    parameters = [:i, conf[:in], :y, :'b:v', "#{conf[:vbrate]}k",
                  :f, "ogg", :acodec, "libvorbis", :vcodec, "libtheora"]
              Severity: Major
              Found in plugins/html5_video/lib/video_processor/ffmpeg.rb and 1 other location - About 2 hrs to fix
              plugins/html5_video/lib/video_processor/ffmpeg.rb on lines 270..281

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 92.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def convert2webm(conf)
    conf[:type] = :WEBM
    conf[:vbrate] ||= 600
    parameters = [:i, conf[:in], :y, :'b:v', "#{conf[:vbrate]}k",
                  :f, "webm", :acodec, "libvorbis", :vcodec, "libvpx"]
              Severity: Major
              Found in plugins/html5_video/lib/video_processor/ffmpeg.rb and 1 other location - About 2 hrs to fix
              plugins/html5_video/lib/video_processor/ffmpeg.rb on lines 240..252

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 92.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status