Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/lattes_curriculum/lib/lattes_curriculum_plugin.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method profile_editor_controller_filters has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def profile_editor_controller_filters
    validate_lattes_url_block = proc do
      parameters = params.to_h.with_indifferent_access
      if request.post?
        if !parameters[:academic_infos].blank?
Severity: Minor
Found in plugins/lattes_curriculum/lib/lattes_curriculum_plugin.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method profile_editor_controller_filters has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def profile_editor_controller_filters
    validate_lattes_url_block = proc do
      parameters = params.to_h.with_indifferent_access
      if request.post?
        if !parameters[:academic_infos].blank?
Severity: Minor
Found in plugins/lattes_curriculum/lib/lattes_curriculum_plugin.rb - About 1 hr to fix

    Method account_controller_filters has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def account_controller_filters
    validate_lattes_url_block = proc do
      parameters = params.to_h.with_indifferent_access
      if request.post?
        parameters[:profile_data] ||= {}
    Severity: Minor
    Found in plugins/lattes_curriculum/lib/lattes_curriculum_plugin.rb - About 1 hr to fix

      Method account_controller_filters has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def account_controller_filters
    validate_lattes_url_block = proc do
      parameters = params.to_h.with_indifferent_access
      if request.post?
        parameters[:profile_data] ||= {}
      Severity: Minor
      Found in plugins/lattes_curriculum/lib/lattes_curriculum_plugin.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status