Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/ldap/lib/ldap_authentication.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method get_user_dn has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def get_user_dn(login, password)
      ldap_con = nil
      if self.account && self.account.include?("$login")
        ldap_con = initialize_ldap_con(self.account.sub("$login", Net::LDAP::DN.escape(login)), password)
      else
Severity: Minor
Found in plugins/ldap/lib/ldap_authentication.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_user_dn has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def get_user_dn(login, password)
      ldap_con = nil
      if self.account && self.account.include?("$login")
        ldap_con = initialize_ldap_con(self.account.sub("$login", Net::LDAP::DN.escape(login)), password)
      else
Severity: Minor
Found in plugins/ldap/lib/ldap_authentication.rb - About 1 hr to fix

    Method get_attr has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.get_attr(entry, attr_name)
      if !attr_name.blank?
        val = entry[attr_name].is_a?(Array) ? entry[attr_name].first : entry[attr_name]
        if val.nil?
          Rails.logger.warn "LDAP entry #{entry.dn} has no attr #{attr_name}."
    Severity: Minor
    Found in plugins/ldap/lib/ldap_authentication.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status