Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/mailing_list/lib/mailing_list_plugin/process_reply_job.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method perform has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def perform
    log_email_reception

    return log("Empty message!") if message.blank?
Severity: Minor
Found in plugins/mailing_list/lib/mailing_list_plugin/process_reply_job.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def perform
    log_email_reception

    return log("Empty message!") if message.blank?
Severity: Minor
Found in plugins/mailing_list/lib/mailing_list_plugin/process_reply_job.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

        return log("Unknown referenced content [#{reply_uuid}]!") if article.blank?
    Severity: Major
    Found in plugins/mailing_list/lib/mailing_list_plugin/process_reply_job.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return log("Ignore email from us [#{administrator_email}]") if from == administrator_email
      Severity: Major
      Found in plugins/mailing_list/lib/mailing_list_plugin/process_reply_job.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return log("Article does not accept comments!") if !article.accept_comments?
        Severity: Major
        Found in plugins/mailing_list/lib/mailing_list_plugin/process_reply_job.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status