Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/orders/lib/terms_helper.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method hash_diff has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def self.hash_diff(h1, h2, inverse = true, path = [], &block)
    block ||= proc { |v1, v2| v1 == v2 }

    h1.each do |k1, v1|
      v2 = h2[k1] rescue nil
Severity: Minor
Found in plugins/orders/lib/terms_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method translated_terms has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def translated_terms(keys = Keys, translations = TermsHelper.translations, transformations = Transformations, sep = I18nSeparator)
      translated_terms = (translations[I18n.locale] ||= {})
      translated_terms = (translated_terms[i18n_scope] ||= {})

      return translated_terms if translated_terms.present?
Severity: Minor
Found in plugins/orders/lib/terms_helper.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hash_diff has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def self.hash_diff(h1, h2, inverse = true, path = [], &block)
Severity: Minor
Found in plugins/orders/lib/terms_helper.rb - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status