Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/orders/models/orders_plugin/item.rb

Summary

Maintainability
D
2 days
Test Coverage

Method quantity_price_data has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

  def quantity_price_data(actor_name)
    data = { flags: {} }
    statuses = ::OrdersPlugin::Order::Statuses
    statuses_data = data[:statuses] = {}
Severity: Minor
Found in plugins/orders/models/orders_plugin/item.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Item has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

class OrdersPlugin::Item < ApplicationRecord
  attr_accessible :order, :sale, :purchase,
                  :product, :product_id,
                  :price, :name
Severity: Minor
Found in plugins/orders/models/orders_plugin/item.rb - About 3 hrs to fix

    Method quantity_price_data has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def quantity_price_data(actor_name)
    data = { flags: {} }
    statuses = ::OrdersPlugin::Order::Statuses
    statuses_data = data[:statuses] = {}
    Severity: Major
    Found in plugins/orders/models/orders_plugin/item.rb - About 2 hrs to fix

      File item.rb has 268 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class OrdersPlugin::Item < ApplicationRecord
  attr_accessible :order, :sale, :purchase,
                  :product, :product_id,
                  :price, :name
      Severity: Minor
      Found in plugins/orders/models/orders_plugin/item.rb - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              self.send :define_method, "total_#{price}" do |items = nil|
        items ||= (self.ordered_items rescue nil) || self.items
        items.collect(&price).inject(0) { |sum, p| sum + p.to_f }
        Severity: Minor
        Found in plugins/orders/models/orders_plugin/item.rb and 1 other location - About 35 mins to fix
        plugins/orders/models/orders_plugin/item.rb on lines 81..83

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              self.send :define_method, "total_#{quantity}" do |items = nil|
        items ||= (self.ordered_items rescue nil) || self.items
        items.collect(&quantity).inject(0) { |sum, q| sum + q.to_f }
        Severity: Minor
        Found in plugins/orders/models/orders_plugin/item.rb and 1 other location - About 35 mins to fix
        plugins/orders/models/orders_plugin/item.rb on lines 85..87

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status