Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/orders_cycle/models/orders_cycle_plugin/sale.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method remove_purchases_items has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def remove_purchases_items
    ApplicationRecord.transaction do
      self.items.each do |item|
        next unless supplier_product = item.product.supplier_product
        next unless purchase = supplier_product.orders_cycles_purchases.for_cycle(self.cycle).first
Severity: Minor
Found in plugins/orders_cycle/models/orders_cycle_plugin/sale.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add_purchases_items has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def add_purchases_items
    ApplicationRecord.transaction do
      self.items.each do |item|
        next unless supplier_product = item.product.supplier_product
        next unless supplier = supplier_product.profile
Severity: Minor
Found in plugins/orders_cycle/models/orders_cycle_plugin/sale.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status