Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/products/controllers/profile/products_plugin/page_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method edit_input has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def edit_input
      if request.xhr?
        @input = @profile.inputs.find_by id: params.fetch(:id)
        if @input
          if request.post?
Severity: Minor
Found in plugins/products/controllers/profile/products_plugin/page_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method new has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def new
      @no_design_blocks = true
      @category = params[:selected_category_id] ? Category.find(params[:selected_category_id]) : nil
      @product = @profile.products.build(product_category: @category)
      @categories = ProductCategory.top_level_for(environment)
Severity: Minor
Found in plugins/products/controllers/profile/products_plugin/page_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status