Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/suppliers/models/suppliers_plugin/base_product.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class BaseProduct has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class SuppliersPlugin::BaseProduct < Product
  attr_accessible :default_margin_percentage, :margin_percentage, :default_unit, :unit_detail,
                  :supplier_product_attributes

  accepts_nested_attributes_for :supplier_product
Severity: Minor
Found in plugins/suppliers/models/suppliers_plugin/base_product.rb - About 2 hrs to fix

    Method price_with_margins has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def price_with_margins(base_price = nil, margin_source = nil)
    margin_source ||= self
    margin_percentage = margin_source.margin_percentage
    margin_percentage ||= self.profile.margin_percentage if self.profile
    Severity: Minor
    Found in plugins/suppliers/models/suppliers_plugin/base_product.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method search_scope has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.search_scope(scope, params)
    scope = scope.from_supplier_id params[:supplier_id] if params[:supplier_id].present?
    scope = scope.with_available(if params[:available] == "true" then true else false end) if params[:available].present?
    scope = scope.fp_name_like params[:name] if params[:name].present?
    scope = scope.fp_with_product_category_id params[:category_id] if params[:category_id].present?
    Severity: Minor
    Found in plugins/suppliers/models/suppliers_plugin/base_product.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def self.search_scope(scope, params)
    scope = scope.from_supplier_id params[:supplier_id] if params[:supplier_id].present?
    scope = scope.with_available(if params[:available] == "true" then true else false end) if params[:available].present?
    scope = scope.fp_name_like params[:name] if params[:name].present?
    scope = scope.fp_with_product_category_id params[:category_id] if params[:category_id].present?
    Severity: Major
    Found in plugins/suppliers/models/suppliers_plugin/base_product.rb and 1 other location - About 1 hr to fix
    plugins/orders_cycle/models/orders_cycle_plugin/offered_product.rb on lines 37..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status