Sign upLogin

NullVoxPopuli/drawers

View on GitHub
Star
lib/drawers/active_support/dependency_extensions.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method load_missing_constant_error has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def load_missing_constant_error(from_mod, const_name, e)
      # examples
      # - Api::PostsController
      # - PostsController
      qualified_name = qualified_name_for(from_mod, const_name)
Severity: Minor
Found in lib/drawers/active_support/dependency_extensions.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Argument e was shadowed by a local variable before it was used.
Open

      rescue LoadError, NameError => e
Severity: Minor
Found in lib/drawers/active_support/dependency_extensions.rb by rubocop

This cop checks for shadowed arguments.

Example:

# bad

do_something do |foo|
  foo = 42
  puts foo
end

def do_something(foo)
  foo = 42
  puts foo
end

Example:

# good

do_something do |foo|
  foo = foo + 42
  puts foo
end

def do_something(foo)
  foo = foo + 42
  puts foo
end

def do_something(foo)
  puts foo
end

Add an empty line after magic comments. (https://github.com/bbatsov/ruby-style-guide#separate-magic-comments-from-code)
Open

module Drawers
Severity: Minor
Found in lib/drawers/active_support/dependency_extensions.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

There are no issues that match your filters.

Category
Status