Sign upLogin

NullVoxPopuli/spiced_rumby

View on GitHub
Star

Showing 64 of 64 total issues

Missing space after #. (https://github.com/bbatsov/ruby-style-guide#hash-space)
Open

            text msg#, mode: :wrap
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Freeze mutable objects assigned to constants.
Open

      CHAT = '#DDDDDD'
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Freeze mutable objects assigned to constants.
Open

      FOREGROUND = '#ffffff'
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency libnotify should appear before vedeu.
Open

  s.add_runtime_dependency 'libnotify'
Severity: Minor
Found in spiced_rumby.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'

Missing space after #. (https://github.com/bbatsov/ruby-style-guide#hash-space)
Open

            text msg#, mode: :wrap
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

(...) interpreted as grouped expression. (https://github.com/bbatsov/ruby-style-guide#parens-no-spaces)
Open

        print (time.join(' ') + ' ').colorize(:light_magenta)
Severity: Minor
Found in lib/spiced_rumby/debug/cli_output.rb by rubocop

Checks for space between the name of a called method and a left parenthesis.

Example:

# bad

puts (x + y)

Example:

# good

puts(x + y)

Missing space after #. (https://github.com/bbatsov/ruby-style-guide#hash-space)
Open

            text msg#, mode: :wrap
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Put a space before an end-of-line comment.
Open

            text message#, mode: :wrap
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks for missing space between a token and a comment on the same line.

Example:

# bad
1 + 1# this operation does ...

# good
1 + 1 # this operation does ...

Freeze mutable objects assigned to constants.
Open

      WHISPER_NAME = '#004444'
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Freeze mutable objects assigned to constants.
Open

      ALERT = '#ff0000'
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)
Open

          ['All Chat', "Other Chat"] + nodes
Severity: Minor
Found in lib/spiced_rumby/gui/views/contacts.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency codeclimate-test-reporter should appear before pry-byebug.
Open

  s.add_development_dependency 'codeclimate-test-reporter'
Severity: Minor
Found in spiced_rumby.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'

Freeze mutable objects assigned to constants.
Open

  NAME = 'Spiced Rumby'
Severity: Minor
Found in lib/spiced_rumby.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

%w-literals should be delimited by [ and ]. (https://github.com/bbatsov/ruby-style-guide#percent-literal-braces)
Open

    is_debugging = %w(nogui bash b d debug).include?(ARGV.first)
Severity: Minor
Found in lib/spiced_rumby.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Missing space after #. (https://github.com/bbatsov/ruby-style-guide#hash-space)
Open

            text msg#, mode: :wrap
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

(...) interpreted as grouped expression. (https://github.com/bbatsov/ruby-style-guide#parens-no-spaces)
Open

        print (time.join(' ') + ' ').colorize(:magenta)
Severity: Minor
Found in lib/spiced_rumby/debug/cli_output.rb by rubocop

Checks for space between the name of a called method and a left parenthesis.

Example:

# bad

puts (x + y)

Example:

# good

puts(x + y)

Missing space after #. (https://github.com/bbatsov/ruby-style-guide#hash-space)
Open

            text message#, mode: :wrap
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Freeze mutable objects assigned to constants.
Open

      WHISPER_TIME = '#662299'
Severity: Minor
Found in lib/spiced_rumby/gui/colorer.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Extra empty line detected at class body beginning. (https://github.com/bbatsov/ruby-style-guide#empty-lines-around-bodies)
Open


      # Bindings!!!!
Severity: Minor
Found in lib/spiced_rumby/gui/application.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Line is too long. [112/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
Open

                  centre SpicedRumby::NAME + ' is a simple chat client that implements mesh-chat.', width: width
Severity: Minor
Found in lib/spiced_rumby/gui/views/welcome.rb by rubocop
Severity
Category
Status
Source
Language