Sign upLogin

OCA/l10n-canada

View on GitHub
Star

Showing 11 of 11 total issues

Function get_lines has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    def get_lines(self, voucher_lines):
        result = []
        self.number_lines = len(voucher_lines)
        for i in range(0, min(10, self.number_lines)):
            if i < self.number_lines:
Severity: Minor
Found in l10n_ca_account_check_writing/report/l10n_ca_check_print.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File l10n_ca_hr_payroll.py has 255 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding:utf-8 -*-
##############################################################################
#
#    Copyright (C) 2012 Amura Consulting. All Rights Reserved.
#
Severity: Minor
Found in l10n_ca_hr_payroll/l10n_ca_hr_payroll.py - About 2 hrs to fix

Consider simplifying this complex logical expression.
Open

                if voucher_line.amount != 0:
                    # In general, the supplier invoice reference number is a
                    # much better description for writing checks than our own
                    # reference number, but if we don't have it, we might as
                    # well use our internal number
Severity: Critical
Found in l10n_ca_account_check_writing/report/l10n_ca_check_print.py - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Severity: Major
Found in res_partner_attributes_add_BN/models/res_partner.py and 1 other location - About 1 hr to fix
res_partner_attributes_add_NEQ/models/res_partner.py on lines 0..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Severity: Major
Found in res_partner_attributes_add_NEQ/models/res_partner.py and 1 other location - About 1 hr to fix
res_partner_attributes_add_BN/models/res_partner.py on lines 0..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function compute_all has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def compute_all(self, cr, uid, taxes, price_unit, quantity, product=None, partner=None, force_excluded=False):
        """
        :param force_excluded: boolean used to say that we don't want to consider the value of field price_include of
            tax. It's used in encoding by line where you don't matter if you encoded a tax with that boolean to True or
            False
Severity: Minor
Found in account_tax_expense_include_unported/account_tax_expense_include.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function compute_all has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def compute_all(self, cr, uid, taxes, price_unit, quantity, product=None, partner=None, force_excluded=False):
Severity: Major
Found in account_tax_expense_include_unported/account_tax_expense_include.py - About 1 hr to fix

Function _amount_in_words has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _amount_in_words(self, currency_id):
        context = self._context.copy()
        lang = context.get('lang', config.get('lang', None))
        if self.partner_id:
            lang = self.partner_id.lang or lang
Severity: Minor
Found in l10n_ca_account_check_writing/account_voucher.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _get_pays_per_year has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _get_pays_per_year(self, cr, uid, ids, names, arg, context=None):
Severity: Minor
Found in l10n_ca_hr_payroll/l10n_ca_hr_payroll.py - About 45 mins to fix

Function onchange_year has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def onchange_year(self, cr, uid, ids, year, prov=False):
Severity: Minor
Found in l10n_ca_hr_payroll/l10n_ca_hr_payroll.py - About 35 mins to fix

Function rename_columns has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def rename_columns(cr, column_spec):
    """
    Rename table columns. Typically called in the pre script.
    :param column_spec: a hash with table keys, with lists of tuples as \
    values. Tuples consist of (old_name, new_name). Use None for new_name \
Severity: Minor
Found in res_partner_attributes_add_BN/migrations/8.0.1.0/pre-migration.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language