Showing 9 of 11 total issues
Function get_lines
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
def get_lines(self, voucher_lines):
result = []
self.number_lines = len(voucher_lines)
for i in range(0, min(10, self.number_lines)):
if i < self.number_lines:
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File l10n_ca_hr_payroll.py
has 255 lines of code (exceeds 250 allowed). Consider refactoring. Open
# -*- coding:utf-8 -*-
##############################################################################
#
# Copyright (C) 2012 Amura Consulting. All Rights Reserved.
#
- Create a ticketCreate a ticket
Consider simplifying this complex logical expression. Open
if voucher_line.amount != 0:
# In general, the supplier invoice reference number is a
# much better description for writing checks than our own
# reference number, but if we don't have it, we might as
# well use our internal number
- Create a ticketCreate a ticket
Function compute_all
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def compute_all(self, cr, uid, taxes, price_unit, quantity, product=None, partner=None, force_excluded=False):
"""
:param force_excluded: boolean used to say that we don't want to consider the value of field price_include of
tax. It's used in encoding by line where you don't matter if you encoded a tax with that boolean to True or
False
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function compute_all
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
def compute_all(self, cr, uid, taxes, price_unit, quantity, product=None, partner=None, force_excluded=False):
- Create a ticketCreate a ticket
Function _amount_in_words
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def _amount_in_words(self, currency_id):
context = self._context.copy()
lang = context.get('lang', config.get('lang', None))
if self.partner_id:
lang = self.partner_id.lang or lang
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _get_pays_per_year
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def _get_pays_per_year(self, cr, uid, ids, names, arg, context=None):
- Create a ticketCreate a ticket
Function onchange_year
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def onchange_year(self, cr, uid, ids, year, prov=False):
- Create a ticketCreate a ticket
Function rename_columns
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def rename_columns(cr, column_spec):
"""
Rename table columns. Typically called in the pre script.
:param column_spec: a hash with table keys, with lists of tuples as \
values. Tuples consist of (old_name, new_name). Use None for new_name \
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"