Sign upLogin

OCA/l10n-ethiopia

View on GitHub
Star

Showing 8 of 8 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def check_tin(self, cr, uid, ids, context=None):

        res = True
        for partner in self.browse(cr, uid, ids, context=context):
            res = self._check_vat_common(cr, uid, partner.id, 'vat',
Severity: Major
Found in l10n_et_base_vat/res.py and 1 other location - About 3 hrs to fix
l10n_et_base_vat/res.py on lines 72..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def check_vat(self, cr, uid, ids, context=None):

        res = True
        for partner in self.browse(cr, uid, ids, context=context):
            res = self._check_vat_common(cr, uid, partner.id, 'vat_number',
Severity: Major
Found in l10n_et_base_vat/res.py and 1 other location - About 3 hrs to fix
l10n_et_base_vat/res.py on lines 62..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def check_vat_unique(self, cr, uid, ids, context=None):

        res = True
        for partner in self.browse(cr, uid, ids, context=context):
            res = self._check_unique_common(cr, uid, partner.id, 'vat_number',
Severity: Major
Found in l10n_et_base_vat/res.py and 1 other location - About 2 hrs to fix
l10n_et_base_vat/res.py on lines 97..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def check_tin_unique(self, cr, uid, ids, context=None):

        res = True
        for partner in self.browse(cr, uid, ids, context=context):
            res = self._check_unique_common(cr, uid, partner.id, 'vat',
Severity: Major
Found in l10n_et_base_vat/res.py and 1 other location - About 2 hrs to fix
l10n_et_base_vat/res.py on lines 106..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _check_vat_common has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _check_vat_common(self, cr, uid, _id, field_name, field_value,
Severity: Major
Found in l10n_et_base_vat/res.py - About 50 mins to fix

    Function _check_unique_common has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _check_unique_common(self, cr, uid, _id, field_name, field_value,
    Severity: Minor
    Found in l10n_et_base_vat/res.py - About 45 mins to fix

      Function write has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def write(self, cr, uid, ids, vals, context=None):
      Severity: Minor
      Found in l10n_et_base_vat/res.py - About 35 mins to fix

        Function write has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def write(self, cr, uid, ids, vals, context=None):
        """When the TIN and VAT registration numbers are changed in the,
        company, change them on the partner as well"""

        res = super(res_company, self).write(cr, uid, ids, vals,
        Severity: Minor
        Found in l10n_et_base_vat/res.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language