Sign upLogin

OCA/l10n-italy

View on GitHub
Star
l10n_it_central_journal/central_journal.py

Summary

Maintainability
A
1 hr
Test Coverage

Function _save_print_info has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _save_print_info(self, fiscalyear_id, end_date_print,
Severity: Minor
Found in l10n_it_central_journal/central_journal.py - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def _get_move(self, move_ids):
        move_list = self.pool.get(
            'account.move.line').browse(self.cr, self.uid, move_ids)
        return move_list
    Severity: Minor
    Found in l10n_it_central_journal/central_journal.py and 1 other location - About 45 mins to fix
    l10n_it_vat_registries/vat_registry.py on lines 79..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status