Sign upLogin

OCA/l10n-italy

View on GitHub
Star
l10n_it_ddt/models/sale.py

Summary

Maintainability
C
1 day
Test Coverage

Function action_view_ddt has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def action_view_ddt(self, cr, uid, ids, context=None):
        mod_obj = self.pool.get('ir.model.data')
        act_obj = self.pool.get('ir.actions.act_window')

        result = mod_obj.get_object_reference(
Severity: Minor
Found in l10n_it_ddt/models/sale.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onchange_partner_id has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def onchange_partner_id(self, cr, uid, ids, partner_id, context=None):
Severity: Minor
Found in l10n_it_ddt/models/sale.py - About 35 mins to fix

    Function _make_invoice has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _make_invoice(self, cr, uid, order, lines, context=None):
    Severity: Minor
    Found in l10n_it_ddt/models/sale.py - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if partner_id:
            partner = self.pool.get('res.partner').browse(cr, uid, partner_id)
            result['value'][
                'carriage_condition_id'] = partner.carriage_condition_id.id
            result['value'][
      Severity: Major
      Found in l10n_it_ddt/models/sale.py and 1 other location - About 6 hrs to fix
      l10n_it_ddt/models/account.py on lines 42..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  result['views'] = [(res and res[1] or False, 'form')]
      Severity: Minor
      Found in l10n_it_ddt/models/sale.py and 1 other location - About 30 mins to fix
      l10n_it_ricevute_bancarie/wizard/wizard_riba_issue.py on lines 137..137

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status