Sign upLogin

OCA/l10n-italy

View on GitHub
Star
l10n_it_fatturapa_pec/models/fetchmail.py

Summary

Maintainability
C
1 day
Test Coverage

Function fetch_mail has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
Open

    def fetch_mail(self):
        for server in self:
            if not server.is_fatturapa_pec:
                super(Fetchmail, server).fetch_mail()
            else:
Severity: Minor
Found in l10n_it_fatturapa_pec/models/fetchmail.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                            if num_messages < MAX_POP_MESSAGES:
                                break
                            pop_server.quit()
Severity: Major
Found in l10n_it_fatturapa_pec/models/fetchmail.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                for num in range(
                                    1, min(MAX_POP_MESSAGES, num_messages) + 1
                            ):
                                (header, messages, octets) = pop_server.retr(
                                    num)
    Severity: Major
    Found in l10n_it_fatturapa_pec/models/fetchmail.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status