Sign upLogin

OCA/l10n-italy

View on GitHub
Star
l10n_it_reverse_charge/models/account_invoice.py

Summary

Maintainability
C
1 day
Test Coverage

Function generate_self_invoice has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    def generate_self_invoice(self):
        rc_type = self.fiscal_position.rc_type_id
        if not rc_type.payment_journal_id.default_credit_account_id:
            raise UserError(
                _('There is no default credit account defined \n'
Severity: Minor
Found in l10n_it_reverse_charge/models/account_invoice.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File account_invoice.py has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# Copyright 2017 Davide Corio
# Copyright 2017 Alex Comba - Agile Business Group
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
Severity: Minor
Found in l10n_it_reverse_charge/models/account_invoice.py - About 3 hrs to fix

    Function action_cancel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def action_cancel(self):
        for inv in self:
            rc_type = inv.fiscal_position.rc_type_id
            if (
                rc_type and
    Severity: Minor
    Found in l10n_it_reverse_charge/models/account_invoice.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

            if not rc_type.payment_journal_id.default_credit_account_id:
            raise UserError(
                _('There is no default credit account defined \n'
                  'on journal "%s".') % rc_type.payment_journal_id.name)
    Severity: Major
    Found in l10n_it_reverse_charge/models/account_invoice.py and 6 other locations - About 35 mins to fix
    l10n_it_fatturapa_out/models/attachment.py on lines 36..39
    l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py on lines 786..789
    l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py on lines 790..793
    l10n_it_fatturapa_out_ddt/wizard/wizard_export_fatturapa.py on lines 82..84
    l10n_it_fatturapa_out_wt/wizard/wizard_export_fatturapa.py on lines 129..132
    l10n_it_fatturapa_out_wt/wizard/wizard_export_fatturapa.py on lines 133..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status