Sign upLogin

OCA/management-system

View on GitHub
Star

Showing 60 of 60 total issues

Function get_lines_by_procedure has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def get_lines_by_procedure(self, verification_lines):
        p = []
        for l in verification_lines:
            if l.procedure_id.id:
                proc_nm = self.pool.get('document.page').read(
Severity: Minor
Found in mgmtsystem_audit/report/verification_list.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function message_auto_subscribe has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def message_auto_subscribe(
Severity: Minor
Found in mgmtsystem_audit/models/mgmtsystem_audit.py - About 45 mins to fix

Function _is_valid_threshold has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _is_valid_threshold(self, cr, uid, ids, field_name, arg, context=None):
Severity: Minor
Found in mgmtsystem_kpi/mgmtsystem_kpi.py - About 45 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        action.write({
            "stage_id": self.env['mgmtsystem.action.stage'].search([
                ('name', '=', "Closed"),
Severity: Minor
Found in mgmtsystem_nonconformity/tests/test_workflows.py and 1 other location - About 45 mins to fix
mgmtsystem_nonconformity/tests/test_workflows.py on lines 208..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function message_auto_subscribe has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def message_auto_subscribe(
Severity: Minor
Found in mgmtsystem_nonconformity_deptm/mgmtsystem_nonconformity.py - About 45 mins to fix

Function _complete_name has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _complete_name(self, cr, uid, ids, name, args, context=None):
Severity: Minor
Found in mgmtsystem_nonconformity_project/models/mgmtsystem_nonconformity_project.py - About 45 mins to fix

Function _display_last_kpi_value has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _display_last_kpi_value(
Severity: Minor
Found in mgmtsystem_kpi/mgmtsystem_kpi.py - About 45 mins to fix

Function compute_max_value has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def compute_max_value(self, cr, uid, ids, field_name, arg, context=None):
Severity: Minor
Found in mgmtsystem_kpi/mgmtsystem_kpi.py - About 45 mins to fix

Function get_color has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def get_color(self, cr, uid, ids, kpi_value, context=None):
        if context is None:
            context = {}

        color = '#FFFFFF'
Severity: Minor
Found in mgmtsystem_kpi/mgmtsystem_kpi.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _generate_invalid_message has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _generate_invalid_message(
Severity: Minor
Found in mgmtsystem_kpi/mgmtsystem_kpi.py - About 45 mins to fix

Function _is_valid_range has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _is_valid_range(self, cr, uid, ids, field_name, arg, context=None):
Severity: Minor
Found in mgmtsystem_kpi/mgmtsystem_kpi.py - About 45 mins to fix

Function _generate_invalid_message has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _generate_invalid_message(
Severity: Minor
Found in mgmtsystem_kpi/mgmtsystem_kpi.py - About 45 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        immediate_action.write({
            "stage_id": self.env['mgmtsystem.action.stage'].search([
                ('name', '=', "Closed"),
Severity: Minor
Found in mgmtsystem_nonconformity/tests/test_workflows.py and 1 other location - About 45 mins to fix
mgmtsystem_nonconformity/tests/test_workflows.py on lines 218..220

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function compute_min_value has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def compute_min_value(self, cr, uid, ids, field_name, arg, context=None):
Severity: Minor
Found in mgmtsystem_kpi/mgmtsystem_kpi.py - About 45 mins to fix

Function update_next_execution_date has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def update_next_execution_date(self, cr, uid, ids, context=None):
        if context is None:
            context = {}

        for obj in self.browse(cr, uid, ids):
Severity: Minor
Found in mgmtsystem_kpi/mgmtsystem_kpi.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function try_invalid_signal has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def try_invalid_signal(self, obj, signal_name, state, msg=None):
Severity: Minor
Found in mgmtsystem_nonconformity/tests/test_workflows.py - About 35 mins to fix

Function onchange_department_id has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def onchange_department_id(self, cr, uid, ids, new_id, context=None):
Severity: Minor
Found in mgmtsystem_nonconformity_deptm/mgmtsystem_nonconformity.py - About 35 mins to fix

Function get_color has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def get_color(self, cr, uid, ids, kpi_value, context=None):
Severity: Minor
Found in mgmtsystem_kpi/mgmtsystem_kpi.py - About 35 mins to fix

Function onchange_department_id has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def onchange_department_id(self, cr, uid, ids, new_id, context=None):
        result = {}
        if new_id:
            deptm = self.pool['hr.department'].browse(
                cr, uid, new_id, context=context
Severity: Minor
Found in mgmtsystem_nonconformity_deptm/mgmtsystem_nonconformity.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function wkf_open has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def wkf_open(self):
        """Change state from pending approval to in progress, and Open
        the related actions
        """
        self.ensure_one()
Severity: Minor
Found in mgmtsystem_nonconformity/models/mgmtsystem_nonconformity.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language