Sign upLogin

OCA/management-system

View on GitHub
Star
mgmtsystem_nonconformity/tests/test_workflows.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function test_workflow has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def test_workflow(self):

        conf_obj = self.conf_m.create({
            "manager_user_id": self.env.user.id,
            "partner_id": self.partner_obj[0].id,
Severity: Major
Found in mgmtsystem_nonconformity/tests/test_workflows.py - About 2 hrs to fix

Function try_invalid_signal has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def try_invalid_signal(self, obj, signal_name, state, msg=None):
Severity: Minor
Found in mgmtsystem_nonconformity/tests/test_workflows.py - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        immediate_action.write({
            "stage_id": self.env['mgmtsystem.action.stage'].search([
                ('name', '=', "Closed"),
Severity: Minor
Found in mgmtsystem_nonconformity/tests/test_workflows.py and 1 other location - About 45 mins to fix
mgmtsystem_nonconformity/tests/test_workflows.py on lines 218..220

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        action.write({
            "stage_id": self.env['mgmtsystem.action.stage'].search([
                ('name', '=', "Closed"),
Severity: Minor
Found in mgmtsystem_nonconformity/tests/test_workflows.py and 1 other location - About 45 mins to fix
mgmtsystem_nonconformity/tests/test_workflows.py on lines 208..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status