Showing 163 of 163 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
logged_query(
cr,
"""
UPDATE ir_property
SET res_id = replace(res_id, %(old_string)s, %(new_string)s)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 35.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function update_aliases has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def update_aliases(Similar blocks of code found in 2 locations. Consider refactoring. Open
document
.querySelector("#flyout-search-form")
.addEventListener("focusin", () => {
const event = new CustomEvent("readthedocs-search-show");
document.dispatchEvent(event);- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 49.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
document
.querySelector("[role='search'] input")
.addEventListener("focusin", () => {
const event = new CustomEvent("readthedocs-search-show");
document.dispatchEvent(event);- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 49.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Consider simplifying this complex logical expression. Open
if (
[...excludedTerms].some(
(term) =>
terms[term] === file ||
titleTerms[term] === file ||Function m2o_to_x2m has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def m2o_to_x2m(cr, model, table, field, source_field):Function _change_reference_refs_orm has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def _change_reference_refs_orm(Function _delete_records_sql has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def _delete_records_sql(Function _change_reference_refs_sql has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def _change_reference_refs_sql(Function _change_translations_sql has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def _change_translations_sql(Function convert_old_style_tax_tag_to_new has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def convert_old_style_tax_tag_to_new(Function set_defaults has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def set_defaults(cr, pool, default_spec, force=False, use_orm=False):Function convert_field_html_string_13to14 has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def convert_field_html_string_13to14(Function _change_many2many_refs_orm has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def _change_many2many_refs_orm(Function convert_field_bootstrap_4to5 has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def convert_field_bootstrap_4to5(Function load_data has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def load_data(env_or_cr, module_name, filename, idref=None, mode="init"):Function m2o_to_m2m has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def m2o_to_m2m(cr, model, table, field, source_field):Function _change_translations_orm has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def _change_translations_orm(Function date_to_datetime_tz has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def date_to_datetime_tz(Function convert_field_bootstrap_3to4 has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def convert_field_bootstrap_3to4(