Sign upLogin

OCA/server-tools

View on GitHub
Star
base_concurrency/res_users.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function _login has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def _login(self, db, login, password):
        if not password:
            return False
        user_id = False
        cr = self.pool.cursor()
Severity: Minor
Found in base_concurrency/res_users.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _get_login_date has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _get_login_date(self, cr, uid, ids, name, args, context=None):
Severity: Minor
Found in base_concurrency/res_users.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status