Sign upLogin

OCA/server-tools

View on GitHub
Star
base_report_auto_create_qweb/models/report_xml.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def create(self, values):
        values['report_name'] = self._format_template_name(
            values.get('report_name', ''))
        if (values.get('report_type') in ['qweb-pdf', 'qweb-html'] and
                values.get('report_name') and
Severity: Minor
Found in base_report_auto_create_qweb/models/report_xml.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _create_qweb has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _create_qweb(self, name, qweb_name, module, model, arch):
Severity: Minor
Found in base_report_auto_create_qweb/models/report_xml.py - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            module = '%s_%s' % (
            self.report_name.split('.')[0], suffix.lower())
    Severity: Minor
    Found in base_report_auto_create_qweb/models/report_xml.py and 1 other location - About 30 mins to fix
    base_report_auto_create_qweb/models/report_xml.py on lines 108..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            report = '%s_%s' % (self.report_name.split('.')[1], suffix.lower())
    Severity: Minor
    Found in base_report_auto_create_qweb/models/report_xml.py and 1 other location - About 30 mins to fix
    base_report_auto_create_qweb/models/report_xml.py on lines 106..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status