Sign upLogin

OCA/server-tools

View on GitHub
Star
fetchmail_attach_from_folder/wizard/attach_mail_manually.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function default_get has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def default_get(self, cr, uid, fields_list, context=None):
        if context is None:
            context = {}

        defaults = super(attach_mail_manually, self).default_get(
Severity: Minor
Found in fetchmail_attach_from_folder/wizard/attach_mail_manually.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fields_view_get has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def fields_view_get(self, cr, user, view_id=None, view_type='form',
Severity: Major
Found in fetchmail_attach_from_folder/wizard/attach_mail_manually.py - About 50 mins to fix

    Function attach_mails has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def attach_mails(self, cr, uid, ids, context=None):
        for this in self.browse(cr, uid, ids, context):
            for mail in this.mail_ids:
                connection = this.folder_id.server_id.connect()
                connection.select(this.folder_id.path)
    Severity: Minor
    Found in fetchmail_attach_from_folder/wizard/attach_mail_manually.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status