Sign upLogin

OCA/server-tools

View on GitHub
Star
html_image_url_extractor/models/ir_fields_converter.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function imgs_from_html has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    def imgs_from_html(self, html_content, limit=None, fail=False):
        """Extract all images in order from an HTML field in a generator.

        :param str html_content:
            HTML contents from where to extract the images.
Severity: Minor
Found in html_image_url_extractor/models/ir_fields_converter.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status