Sign upLogin

OCA/server-tools

View on GitHub
Star
sql_request_abstract/models/sql_request_mixin.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function _execute_sql_request has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def _execute_sql_request(
            self, params=None, mode='fetchall', rollback=True,
            view_name=False, copy_options="CSV HEADER DELIMITER ';'"):
        """Execute a SQL request on the current database.
Severity: Minor
Found in sql_request_abstract/models/sql_request_mixin.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _execute_sql_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _execute_sql_request(
Severity: Minor
Found in sql_request_abstract/models/sql_request_mixin.py - About 35 mins to fix

    Function button_validate_sql_expression has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def button_validate_sql_expression(self):
        for item in self:
            if item._clean_query_enabled:
                item._clean_query()
            if item._check_prohibited_words_enabled:
    Severity: Minor
    Found in sql_request_abstract/models/sql_request_mixin.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status