Sign upLogin

OCA/server-tools

View on GitHub
Star
users_ldap_populate/models/users_ldap.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function action_populate has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    def action_populate(self, cr, uid, ids, context=None):
        """
        Prepopulate the user table from one or more LDAP resources.

        Obviously, the option to create users must be toggled in
Severity: Minor
Found in users_ldap_populate/models/users_ldap.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function do_deactivate_unknown_users has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def do_deactivate_unknown_users(
Severity: Minor
Found in users_ldap_populate/models/users_ldap.py - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status