Sign upLogin

OCA/server-tools

View on GitHub
Star
users_ldap_push/models/res_users.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function push_to_ldap has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def push_to_ldap(self, values):
        for this in self:
            if not values.get('is_ldap_user') and not this.is_ldap_user:
                continue
            if not this._push_to_ldap_possible(values):
Severity: Minor
Found in users_ldap_push/models/res_users.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status