Showing 40 of 40 total issues
Method parse has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring. Open
def parse(io, quot = '"', sep = ',', fail_on_malformed = true, column = NoConversion.new, &block)
q, s, row, inquot, clean, maybe, table, field, endline = quot.ord, sep.ord, [], false, true, false, nil, true, false
io.each_byte do |c|
next if c == ?\r.ord- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File stringio.rb has 512 lines of code (exceeds 250 allowed). Consider refactoring. Open
class StringIO
attr_reader :string, :pos
# strio.lineno -> integerClass StringIO has 56 methods (exceeds 20 allowed). Consider refactoring. Open
class StringIO
attr_reader :string, :pos
# strio.lineno -> integerFile motion-csv.rb has 378 lines of code (exceeds 250 allowed). Consider refactoring. Open
module MotionCSV
class Table < Array
class << selfMethod puts has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring. Open
def puts(*args)
if args.empty?
write("\n")
else
args.each do |arg|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method read has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
def read(length = nil, buffer = String.new)
raise IOError, "not opened for reading" unless @readable
raise TypeError unless buffer.respond_to?(:to_str)
buffer = buffer.to_str
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getline has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def getline(sep = $/, lim = nil)
raise(IOError, "not opened for reading") unless @readable
return nil if eof?
offset = limit = -1- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
def parse(io, quot = '"', sep = ',', fail_on_malformed = true, column = NoConversion.new, &block)
q, s, row, inquot, clean, maybe, table, field, endline = quot.ord, sep.ord, [], false, true, false, nil, true, false
io.each_byte do |c|
next if c == ?\r.ordMethod quot_row has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def quot_row(row, q = '"', s = ',', numquot = false)
num_quot = /(?:[#{q}#{s}\n]|^\d+$)/
need_quot = /[#{q}#{s}\n]/
row.map do |val|
if val.nil?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method write has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def write(str)
raise(IOError, "not opened for writing") unless @writable
raise(IOError, "not modifiable string") if @string.frozen?
str = str.to_s- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_mode_from_string has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def set_mode_from_string(mode)
@readable = @writable = @append = false
case mode
when "r", "rb"- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getline has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
def getline(sep = $/, lim = nil)
raise(IOError, "not opened for reading") unless @readable
return nil if eof?
offset = limit = -1Method putc has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def putc(obj)
raise(IOError, "not opened for writing") unless @writable
if obj.is_a?(String)
char = obj[0]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method puts has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def puts(*args)
if args.empty?
write("\n")
else
args.each do |arg|Similar blocks of code found in 2 locations. Consider refactoring. Open
def ungetc(chars)
raise(IOError, "not opened for reading") unless @readable
return nil if chars == nil
chars = chars.chr if chars.kind_of?(Fixnum)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 51.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
def ungetbyte(bytes)
raise(IOError, "not opened for reading") unless @readable
return nil if bytes == nil
bytes = bytes.chr if bytes.kind_of?(Fixnum)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 51.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method reopen has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def reopen(str=nil, mode=nil)
if str == nil && mode == nil
mode = 'w+'
elsif !str.kind_of?(String) && mode == nil
raise TypeError unless str.respond_to?(:to_strio)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method [] has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def [](*is)
is.each do |i|
val = if i.is_a? Fixnum
super
else- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getline_args has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def getline_args(sep = $/, lim = nil)
if lim == nil && !sep.kind_of?(String)
if !sep.respond_to?(:to_str)
lim = sep
sep = nil- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method << has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def <<(row)
@lines += 1
if !row.is_a?(Row)
row = Row.new(self, row, @lines)
end- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"