Sign upLogin

OWASP/SSO_Project

View on GitHub
Star

Showing 49 of 52 total issues

Function exports has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (on, config) => {
    config.baseUrl = "https://"+frontendHost+"/#";
    config.env.FRONTENDHOST = frontendHost;
    config.env.MAILHOST = mailHost;
Severity: Major
Found in cypress/plugins/index.js - About 3 hrs to fix

    Function onFlowIn has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async onFlowIn(req, res, next) {
        const dataIn = req.query.d || req.body.d;
        const pageId = req.query.id || req.body.id;
        if(!pageId || isNaN(pageId)) {
            return res.status(400).send("Invalid flow request - missing parameters");
    Severity: Major
    Found in js-backend/flows/sso-flow.js - About 3 hrs to fix

      Function onFlowOut has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          onFlowOut(req, res, next) {
        const jwtRequest = req.ssoRequest;
        if(!jwtRequest) {
            return res.status(400).send("No SSO request forwarded");
        }
      Severity: Major
      Found in js-backend/flows/sso-flow.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for (let websiteIndex of Object.keys(this.customPages)) {
            const thisPage = this.customPages[websiteIndex];
            if(!thisPage.hasOwnProperty("syslog")) continue;
            
            scheduledPromises.push(this.cefSend(thisPage.syslog, {
        Severity: Major
        Found in js-backend/utils/audit.js and 1 other location - About 2 hrs to fix
        js-backend/utils/audit.js on lines 16..23

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 85.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for (let websiteIndex of Object.keys(this.customPages)) {
            const thisPage = this.customPages[websiteIndex];
            if(!thisPage.hasOwnProperty("syslog")) continue;

            scheduledPromises.push(this.cefSend(thisPage.syslog, {
        Severity: Major
        Found in js-backend/utils/audit.js and 1 other location - About 2 hrs to fix
        js-backend/utils/audit.js on lines 93..100

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 85.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exports has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = (on, config) => {
    config.baseUrl = "https://"+frontendHost+"/#";
    config.env.FRONTENDHOST = frontendHost;
    config.env.MAILHOST = mailHost;
        Severity: Minor
        Found in cypress/plugins/index.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function checkCustomCa has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

            async checkCustomCa(req, res, next) {
        let jwtRequest;
        try {
            jwtRequest = await JWT.verify(req.body.token, this.ownJwtToken, {
                maxAge: JWT.age().MEDIUM,
        Severity: Minor
        Found in js-backend/flows/authenticator-cert.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    this.pwUtil.hashPassword(newPassword).then(hash => {
                this.db.execute("INSERT INTO passwords (userId, password) VALUES(?, ?)", [userId, hash], (err) => {
                    if(err) return reject(err);
                    
                    resolve(userId);
        Severity: Major
        Found in js-backend/utils/user.js and 1 other location - About 2 hrs to fix
        js-backend/utils/user.js on lines 89..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                this.pwUtil.hashPassword(password).then(hash => {
                            this.db.execute("INSERT INTO passwords (userId, password) VALUES(?, ?)", [userId, hash], (err) => {
                                if(err) return reject(err);
                                
                                resolve(userId);
        Severity: Major
        Found in js-backend/utils/user.js and 1 other location - About 2 hrs to fix
        js-backend/utils/user.js on lines 104..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function checkCustomCa has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async checkCustomCa(req, res, next) {
        let jwtRequest;
        try {
            jwtRequest = await JWT.verify(req.body.token, this.ownJwtToken, {
                maxAge: JWT.age().MEDIUM,
        Severity: Major
        Found in js-backend/flows/authenticator-cert.js - About 2 hrs to fix

          Function getCert has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              getCert(req, res) {
        let cert = req.connection.getPeerCertificate(true);
        //console.log("cert login", cert, req.user)
        
        if(!cert.hasOwnProperty("subject") || !cert.subject) {
          Severity: Minor
          Found in js-backend/flows/authenticator-cert.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getCert has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              getCert(req, res) {
        let cert = req.connection.getPeerCertificate(true);
        //console.log("cert login", cert, req.user)
        
        if(!cert.hasOwnProperty("subject") || !cert.subject) {
          Severity: Minor
          Found in js-backend/flows/authenticator-cert.js - About 1 hr to fix

            Function addRoutes has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                addRoutes(app) {
        app.use(this.ssoFlow.parseSSOHeader.bind(this.ssoFlow));
        app.get("/email-confirm", this.localAuthFlow.onEmailConfirm.bind(this.localAuthFlow), MiddlewareHelper.createAuthToken.bind(MiddlewareHelper));
    
        app.post("/authenticator/delete", MiddlewareHelper.isAuthenticated.bind(MiddlewareHelper), this.authenticatorFlow.onAuthenticatorDelete.bind(this.authenticatorFlow), MiddlewareHelper.showSuccess);
            Severity: Minor
            Found in js-backend/flows/index.js - About 1 hr to fix

              Function onSamlIn has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  onSamlIn(req, res, next) {
        samlp.parseRequest(req, (err, samlData) => {
            if(err) {
                console.error(err);
                return res.status(400).send("Invalid SAML request");
              Severity: Minor
              Found in js-backend/flows/sso-flow.js - About 1 hr to fix

                Function onFidoLoginPost has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    onFidoLoginPost(req, res, next) {
        const userId = req.user.id;
        const logResponse = req.body.response;
        
        let thisCred, challenge;
                Severity: Minor
                Found in js-backend/flows/authenticator.js - About 1 hr to fix

                  Function onCertLogin has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      async onCertLogin(req, res, next) {
        const certResp = this.getCert(req, res);
        if(certResp === false) {
            return;
        }
                  Severity: Minor
                  Found in js-backend/flows/authenticator-cert.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        updateLoginTime(userId) {
        return new Promise((resolve, reject) => {
            this.db.execute("UPDATE users SET last_login = NOW() WHERE id = ?", [userId], (err) => {
                if(err) return reject(err);
                resolve();
                    Severity: Major
                    Found in js-backend/utils/user.js and 1 other location - About 1 hr to fix
                    js-backend/utils/user.js on lines 66..73

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 65.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        manualInvalidateToken(id) {
        return new Promise((resolve, reject) => {
            this.db.execute("DELETE FROM emailConfirm WHERE id = ?", [id], (err) => {
                if(err) return reject(err);
                resolve();
                    Severity: Major
                    Found in js-backend/utils/user.js and 1 other location - About 1 hr to fix
                    js-backend/utils/user.js on lines 140..147

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 65.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                            return Audit.add(req, "authenticator", "login", thisPage.name + " certificate").then(() => {
                            next();
                        }).catch(err => {
                            console.error(err);
                        });
                    Severity: Major
                    Found in js-backend/flows/authenticator-cert.js and 1 other location - About 1 hr to fix
                    js-backend/flows/authenticator-cert.js on lines 123..127

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 64.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                                    Audit.add(req, "authenticator", "login", thisPage.name + " certificate").then(() => {
                                    next();
                                }).catch(err => {
                                    console.error(err);
                                });
                    Severity: Major
                    Found in js-backend/flows/authenticator-cert.js and 1 other location - About 1 hr to fix
                    js-backend/flows/authenticator-cert.js on lines 102..106

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 64.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language