OWASP/SSO_Project

View on GitHub
js-backend/flows/authenticator.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function onFidoLoginPost has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    onFidoLoginPost(req, res, next) {
        const userId = req.user.id;
        const logResponse = req.body.response;
        
        let thisCred, challenge;
Severity: Minor
Found in js-backend/flows/authenticator.js - About 1 hr to fix

    Function onFidoRegisterPost has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        onFidoRegisterPost(req, res, next) {
            const userId = req.user.id;
            const regResponse = req.body.response;
            const label = req.body.label;
            
    Severity: Minor
    Found in js-backend/flows/authenticator.js - About 1 hr to fix

      Function onFidoLoginGet has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          onFidoLoginGet(req, res, next) {
              const userId = req.user.id;
              
              Promise.all([
                  this.f2l.assertionOptions(),
      Severity: Minor
      Found in js-backend/flows/authenticator.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                JWT.verify(req.body.token, this.ownJwtToken, {
                    maxAge: JWT.age().SHORT,
                    subject: userId,
                }).then(jwtToken => {
                    challenge = jwtToken.challenge;
        Severity: Minor
        Found in js-backend/flows/authenticator.js and 1 other location - About 45 mins to fix
        js-backend/flows/authenticator.js on lines 51..65

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                JWT.verify(req.body.token, this.ownJwtToken, {
                    maxAge: JWT.age().SHORT,
                    subject: userId,
                }).then(regToken => {
                    const challenge = regToken.challenge;
        Severity: Minor
        Found in js-backend/flows/authenticator.js and 1 other location - About 45 mins to fix
        js-backend/flows/authenticator.js on lines 129..136

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status