Sign upLogin

OWASP/cornucopia

View on GitHub
Star

Showing 6 of 6 total issues

File convert.py has 822 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python3
import argparse
import docx2pdf  # type: ignore
import docx  # type: ignore
import fnmatch
Severity: Major
Found in scripts/convert.py - About 1 day to fix

    Function produce_webapp_mappings has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    def produce_webapp_mappings(source_file: Dict[Any, Any], standards_to_add: list[str]) -> Dict[Any, Any]:
    base = {
        "meta": {"edition": "webapp", "component": "mappings", "language": "ALL", "version": CORNUCOPIA_VERSION},
    }
    for indx, suit in enumerate(source_file.copy()["suits"]):
    Severity: Minor
    Found in scripts/gen_mappings.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        for link in cre_object.get("links"):
                        if link.get("document").get("name") == standard:
                            source_file["suits"][indx]["cards"][card_indx][standard] = link.get("document").get(
                                "sectionID"
                            )
    Severity: Major
    Found in scripts/gen_mappings.py - About 45 mins to fix

      Function valid_meta has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def valid_meta(meta: Dict[str, Any], language: str, edition: str, version: str, template: str, layout: str) -> bool:
      Severity: Minor
      Found in scripts/convert.py - About 45 mins to fix

        Function get_mapping_for_edition has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def get_mapping_for_edition(
        Severity: Minor
        Found in scripts/convert.py - About 45 mins to fix

          Function create_edition_from_template has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def create_edition_from_template(
          Severity: Minor
          Found in scripts/convert.py - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language