Sign upLogin

OddGreg/NineCollections

View on GitHub
Star

Showing 32 of 32 total issues

Function data_get has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    function data_get($target, $key, $default = NULL)
    {
        if (is_null($key)) {
            return $target;
        }
Severity: Minor
Found in src/helpers.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    protected function getArrayableItems($items) : array
    {
        if ($items instanceof self) {
            return $items->copy();
        }
Severity: Major
Found in src/Traits/WithItemArrayAccess.php and 1 other location - About 1 hr to fix
src/Attributes.php on lines 177..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    protected function getArrayableItems($items): array
    {
        if ($items instanceof self) {
            return $items->copy();
        }
Severity: Major
Found in src/Attributes.php and 1 other location - About 1 hr to fix
src/Traits/WithItemArrayAccess.php on lines 187..202

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

                return call_user_func_array(static::$macros[$method], $parameters);
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

                return call_user_func_array(static::$macros[$method]->bindTo($this, static::class), $parameters);
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

                return call_user_func_array(Closure::bind(static::$macros[$method], null, static::class), $parameters);
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

                return call_user_func_array(static::$macros[$method], $parameters);
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

            if (static::$macros[$method] instanceof Closure) {
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

        return isset(static::$macros[$name]);
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '::$macros' which will lead to PHP notices.
Open

            if (static::$macros[$method] instanceof Closure) {
Severity: Minor
Found in src/Traits/Macroable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Method data_get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function data_get($target, $key, $default = NULL)
    {
        if (is_null($key)) {
            return $target;
        }
Severity: Minor
Found in src/helpers.php - About 1 hr to fix

    Avoid variables with short names like $ra. Configured minimum length is 3.
    Open

                $ra = explode(':', $tuple);
    Severity: Minor
    Found in src/helpers.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The parameter $encoded_string is not named in camelCase.
    Open

        function tuples($encoded_string) : array
    {
        $array = w($encoded_string, ',');
        $result = [];
    Severity: Minor
    Found in src/helpers.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    Avoid variables with short names like $if. Configured minimum length is 3.
    Open

        function throw_if($if, $exception, $message)
    Severity: Minor
    Found in src/helpers.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $if. Configured minimum length is 3.
    Open

        function throw_if_not($if, $exception, $message)
    Severity: Minor
    Found in src/helpers.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Missing class import via use statement (line '86', column '23').
    Open

                throw new \InvalidArgumentException("Invalid import extension: `$extension`");
    Severity: Minor
    Found in src/Config.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '176', column '23').
    Open

                throw new \InvalidArgumentException("Config base path `$path` does not exist.");
    Severity: Minor
    Found in src/Config.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid too many return statements within this method.
    Open

            return $target;
    Severity: Major
    Found in src/helpers.php - About 30 mins to fix

      Missing class import via use statement (line '53', column '19').
      Open

              throw new \InvalidArgumentException("Attribute '$name' does not exist.");
      Severity: Minor
      Found in src/Attributes.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '70', column '23').
      Open

                  throw new \InvalidArgumentException("Cannot append an already existing key: '$key'");
      Severity: Minor
      Found in src/Traits/WithItemArrayAccess.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Severity
      Category
      Status
      Source
      Language