Sign upLogin

Olian04/brynja

View on GitHub
Star

Showing 11 of 11 total issues

Function buildNode has 167 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function buildNode(
  tagType: string,
  builder: BuilderCB,
): [VNode, IStyles] {
  const ctx: VNode = newVNode({
Severity: Major
Found in src/builder.ts - About 6 hrs to fix

    Function updateNode has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

    export function updateNode(
  newNode: VNode,
  oldNode: VNode,
  elem: HTMLElement,
): void {
    Severity: Minor
    Found in src/updateNode.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function buildNode has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

    export function buildNode(
  tagType: string,
  builder: BuilderCB,
): [VNode, IStyles] {
  const ctx: VNode = newVNode({
    Severity: Minor
    Found in src/builder.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateNode has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function updateNode(
  newNode: VNode,
  oldNode: VNode,
  elem: HTMLElement,
): void {
    Severity: Major
    Found in src/updateNode.ts - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        Object.keys(node.events).forEach((event) => {
    // @ts-ignore
    elem[`on${event}`] = (e) => {
      node.events[event].forEach((cb) => {
        cb(e);
      Severity: Major
      Found in src/renderNode.ts and 1 other location - About 1 hr to fix
      src/updateNode.ts on lines 77..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        for (const event in newNode.events) {
    // @ts-ignore
    elem[`on${event}`] = (e) => {
      newNode.events[event].forEach((cb) => {
        cb(e);
      Severity: Major
      Found in src/updateNode.ts and 1 other location - About 1 hr to fix
      src/renderNode.ts on lines 19..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function renderStyle has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function renderStyle(styles: IStyles): string {
  const renderedStyles = Object.keys(styles).reduce((res, className) => {
    const allSelectors: IStyles = Object.keys(styles[className]).reduce(
      (res: IStyles, key) => {
        if (key.startsWith(':')) {
      Severity: Minor
      Found in src/renderStyles.ts - About 1 hr to fix

        Function Renderer has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function Renderer(config: { rootElement: HTMLElement }): IRenderer {
  let initialRender = true;
  let oldRootNode: VNode | null = null;
  return {
    render(rootBuilder: BuilderCB) {
        Severity: Minor
        Found in src/renderer.ts - About 1 hr to fix

          Function renderedStyles has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const renderedStyles = Object.keys(styles).reduce((res, className) => {
    const allSelectors: IStyles = Object.keys(styles[className]).reduce(
      (res: IStyles, key) => {
        if (key.startsWith(':')) {
          // Extract pseudoClasses
          Severity: Minor
          Found in src/renderStyles.ts - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              export enum Drag {
    Drag = 'drag',
    End = 'dragend',
    Enter = 'dragenter',
    Leave = 'dragleave',
            Severity: Minor
            Found in src/util/events.ts and 1 other location - About 35 mins to fix
            src/util/events.ts on lines 5..14

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              export enum Mouse {
    Click = 'click',
    DoubleClick = 'dblclick',
    Down = 'mousedown',
    Up = 'mouseup',
            Severity: Minor
            Found in src/util/events.ts and 1 other location - About 35 mins to fix
            src/util/events.ts on lines 20..29

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language