OmarElGabry/miniPHP

View on GitHub
app/core/components/SecurityComponent.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function requestRequired has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private function requestRequired(){
        foreach (['Post', 'Ajax', 'Get'] as $method) {
            $key = 'require' . $method;
            if (!empty($this->config[$key])) {
                if (in_array($this->request->param('action'), $this->config[$key], true) || $this->config[$key] === ['*']) {
Severity: Minor
Found in app/core/components/SecurityComponent.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function startup has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function startup(){

        if(!$this->requestRequired()){
            return $this->invalidRequest();
        }
Severity: Minor
Found in app/core/components/SecurityComponent.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function form has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function form($config){

        if(empty($config['fields']) || $this->request->dataSizeOverflow()){
             return false;
        }
Severity: Minor
Found in app/core/components/SecurityComponent.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function secureRequired has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function secureRequired(){
        $key = "requireSecure";
        if(!empty($this->config[$key])){
            if (in_array($this->request->param('action'), $this->config[$key], true) || $this->config[$key] === ['*']) {
                if (!$this->request->isSSL()) {
Severity: Minor
Found in app/core/components/SecurityComponent.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                return $this->invalidRequest();
Severity: Major
Found in app/core/components/SecurityComponent.php - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status