Sign upLogin

OmarElGabry/miniPHP

View on GitHub
Star
app/models/User.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function updateProfileInfo has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function updateProfileInfo($userId, $name, $password, $email, $confirmEmail){

        $database = Database::openConnection();
        $curUser = $this->getProfileInfo($userId);
Severity: Minor
Found in app/models/User.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method updateProfileInfo has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function updateProfileInfo($userId, $name, $password, $email, $confirmEmail){

        $database = Database::openConnection();
        $curUser = $this->getProfileInfo($userId);
Severity: Major
Found in app/models/User.php - About 2 hrs to fix

    Method updateEmail has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function updateEmail($userId, $emailToken){

        if (empty($userId) || empty($emailToken)) {
            return false;
        }
    Severity: Minor
    Found in app/models/User.php - About 1 hr to fix

      Function updateEmail has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function updateEmail($userId, $emailToken){

        if (empty($userId) || empty($emailToken)) {
            return false;
        }
      Severity: Minor
      Found in app/models/User.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updateProfileInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function updateProfileInfo($userId, $name, $password, $email, $confirmEmail){
      Severity: Minor
      Found in app/models/User.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status