Sign upLogin

Ontica/Empiria.Land.Intranet

View on GitHub
Star

Showing 370 of 516 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export interface ReportQuery extends DataTableQuery {
  reportType?: string;
  fromDate?: DateString;
  toDate?: DateString;
  exportTo?: string;
Severity: Minor
Found in src/app/models/reporting.ts and 1 other location - About 30 mins to fix
src/app/models/transaction.ts on lines 30..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.recordingData.getRecordingBook(recordingBookUID)
      .firstValue()
      .then(x => this.setSelectedRecordingBook(x))
      .finally(() => this.setSubmitted(false));
Severity: Minor
Found in src/app/views/registration/recording-book/recording-book-edition.component.ts and 1 other location - About 30 mins to fix
src/app/workspaces/land-transactions/e-sign-main-page/e-sign-main-page.component.ts on lines 268..271

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function setRecorderOfficeAndMunicipalityDataList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  private setRecorderOfficeAndMunicipalityDataList() {
    this.municipalityList = [];

    if (!isEmpty(this.realEstate.recorderOffice)) {
      const recorderOffice =
Severity: Minor
Found in src/app/views/recordable-subjects/real-estate/real-estate-editor.component.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onMonthClicked has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  onMonthClicked(indexClicked) {
    if (this.rangeIndexes.startIndex !== null && this.rangeIndexes.endIndex !== null) {
      this.clearRangeSelection();
    }
Severity: Minor
Found in src/app/shared/form-controls/date-range-picker/month-picker/month-picker.component.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getRegistrationCommandPayload has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  private getRegistrationCommandPayload(): RegistrationCommandPayload {
    Assertion.assert(this.form.valid, 'Programming error: form must be validated before command execution.');

    const formModel = this.form.getRawValue();
Severity: Minor
Found in src/app/views/registration/recording-acts/recording-act-creator.component.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function showProgressLabel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  private showProgressLabel() {
    if (this.isLoading) {
      this.setEllipsis(this.loadingText || 'Cargando');
    } else {
      if (this.subscription) {
Severity: Minor
Found in src/app/shared/indicators/progress-text/progress-text.directive.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ChildRouteGuard has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export const ChildRouteGuard: CanActivateChildFn = (route: ActivatedRouteSnapshot) => {
  if (!isAuthenticated()) {
    return false;
  }
Severity: Minor
Found in src/app/core/security/security.guard.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateFileType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  private validateFileType(file: File) {
    if (this.isFileTypeInConfig('all')) {
      return true;
    }
Severity: Minor
Found in src/app/shared/form-controls/file-control/file-control.component.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isValidDate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  private static isValidDate(year: number, month: number, dayOfMonth: number): boolean {
    const monthsWith30Days = [3, 5, 8, 10];
    const monthsWith31Days = [0, 2, 4, 6, 7, 9, 11];

    if (!(1900 <= year && year <= 2078)) {
Severity: Minor
Found in src/app/core/data-types/date-string-library.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getConfirmMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  private getConfirmMessage(): string {
    const numTransactions = this.transactionList.length;

    const commandType = this.applicableCommandsList.find(x => x.type === this.formWorkflow.commandType);
Severity: Minor
Found in src/app/views/transactions/workflow-commander/workflow-commander.component.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language