Sign upLogin

Ontica/Empiria.Land.Intranet

View on GitHub
Star
src/app/data-services/certification.data.service.ts

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  openCertificate(transactionUID: string, certificateUID: string): EmpObservable<Certificate> {
    Assertion.assertValue(transactionUID, 'transactionUID');
    Assertion.assertValue(certificateUID, 'certificateUID');

    const path = `v5/land/transactions/${transactionUID}/certificates/${certificateUID}/open`;
Severity: Major
Found in src/app/data-services/certification.data.service.ts and 7 other locations - About 3 hrs to fix
src/app/data-services/certification.data.service.ts on lines 49..56
src/app/data-services/recording.data.service.ts on lines 30..38
src/app/data-services/recording.data.service.ts on lines 110..117
src/app/data-services/recording.data.service.ts on lines 180..188
src/app/data-services/recording.data.service.ts on lines 272..280
src/app/data-services/transaction.data.service.ts on lines 152..160
src/app/data-services/transaction.data.service.ts on lines 241..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  closeCertificate(transactionUID: string, certificateUID: string): EmpObservable<Certificate> {
    Assertion.assertValue(transactionUID, 'transactionUID');
    Assertion.assertValue(certificateUID, 'certificateUID');

    const path = `v5/land/transactions/${transactionUID}/certificates/${certificateUID}/close`;
Severity: Major
Found in src/app/data-services/certification.data.service.ts and 7 other locations - About 3 hrs to fix
src/app/data-services/certification.data.service.ts on lines 59..66
src/app/data-services/recording.data.service.ts on lines 30..38
src/app/data-services/recording.data.service.ts on lines 110..117
src/app/data-services/recording.data.service.ts on lines 180..188
src/app/data-services/recording.data.service.ts on lines 272..280
src/app/data-services/transaction.data.service.ts on lines 152..160
src/app/data-services/transaction.data.service.ts on lines 241..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

  createCertificate(transactionUID: string, command: CreateCertificateCommand): EmpObservable<Certificate> {
    Assertion.assertValue(transactionUID, 'transactionUID');
    Assertion.assertValue(command, 'command');

    const path = `v5/land/transactions/${transactionUID}/certificates`;
Severity: Major
Found in src/app/data-services/certification.data.service.ts and 10 other locations - About 2 hrs to fix
src/app/data-services/_access-control.data.service.ts on lines 94..101
src/app/data-services/recording.data.service.ts on lines 99..107
src/app/data-services/recording.data.service.ts on lines 120..128
src/app/data-services/recording.data.service.ts on lines 131..139
src/app/data-services/recording.data.service.ts on lines 156..164
src/app/data-services/recording.data.service.ts on lines 261..269
src/app/data-services/recording.data.service.ts on lines 325..333
src/app/data-services/transaction.data.service.ts on lines 96..104
src/app/data-services/transaction.data.service.ts on lines 194..201
src/app/data-services/transaction.data.service.ts on lines 213..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  getTransactionCertificateTypes(transactionUID: string): EmpObservable<CertificateType[]> {
    Assertion.assertValue(transactionUID, 'transactionUID');

    const path = `v5/land/transactions/${transactionUID}/certificates/certificate-types`;
Severity: Major
Found in src/app/data-services/certification.data.service.ts and 5 other locations - About 2 hrs to fix
src/app/data-services/_access-control.data.service.ts on lines 56..62
src/app/data-services/certification.data.service.ts on lines 30..36
src/app/data-services/recordable-subjects.data.service.ts on lines 124..130
src/app/data-services/recording.data.service.ts on lines 41..47
src/app/data-services/recording.data.service.ts on lines 50..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  getTransactionCertificates(transactionUID: string): EmpObservable<Certificate[]> {
    Assertion.assertValue(transactionUID, 'transactionUID');

    const path = `v5/land/transactions/${transactionUID}/certificates`;
Severity: Major
Found in src/app/data-services/certification.data.service.ts and 5 other locations - About 2 hrs to fix
src/app/data-services/_access-control.data.service.ts on lines 56..62
src/app/data-services/certification.data.service.ts on lines 21..27
src/app/data-services/recordable-subjects.data.service.ts on lines 124..130
src/app/data-services/recording.data.service.ts on lines 41..47
src/app/data-services/recording.data.service.ts on lines 50..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status