Sign upLogin

Ontica/Empiria.Land.Intranet

View on GitHub
Star
src/app/data-services/recordable-subjects.data.service.ts

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Invalid

  getRecordingBookEntries(recordingBookUID: string): EmpObservable<BookEntryShortModel[]> {
    Assertion.assertValue(recordingBookUID, 'recordingBookUID');

    const path = `v5/land/registration/recording-books/${recordingBookUID}/book-entries`;
Severity: Major
Found in src/app/data-services/recordable-subjects.data.service.ts and 5 other locations - About 2 hrs to fix
src/app/data-services/_access-control.data.service.ts on lines 56..62
src/app/data-services/certification.data.service.ts on lines 21..27
src/app/data-services/certification.data.service.ts on lines 30..36
src/app/data-services/recording.data.service.ts on lines 41..47
src/app/data-services/recording.data.service.ts on lines 50..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

  getFullTractIndex(recordableSubjectUID: string): EmpObservable<TractIndex> {
    Assertion.assertValue(recordableSubjectUID, 'recordableSubjectUID');

    const path = `v5/land/registration/recordable-subjects/${recordableSubjectUID}/tract-index`;
Severity: Major
Found in src/app/data-services/recordable-subjects.data.service.ts and 17 other locations - About 1 hr to fix
src/app/data-services/_access-control.data.service.ts on lines 122..128
src/app/data-services/_access-control.data.service.ts on lines 131..137
src/app/data-services/recording.data.service.ts on lines 81..87
src/app/data-services/recording.data.service.ts on lines 90..96
src/app/data-services/recording.data.service.ts on lines 297..303
src/app/data-services/recording.data.service.ts on lines 306..312
src/app/data-services/recording.data.service.ts on lines 348..354
src/app/data-services/recording.data.service.ts on lines 357..363
src/app/data-services/transaction.data.service.ts on lines 59..65
src/app/data-services/transaction.data.service.ts on lines 68..74
src/app/data-services/transaction.data.service.ts on lines 87..93
src/app/data-services/transaction.data.service.ts on lines 107..113
src/app/data-services/transaction.data.service.ts on lines 116..122
src/app/data-services/transaction.data.service.ts on lines 125..131
src/app/data-services/transaction.data.service.ts on lines 143..149
src/app/data-services/transaction.data.service.ts on lines 176..182
src/app/data-services/transaction.data.service.ts on lines 204..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Invalid

  getRecorderOffices(): EmpObservable<RecorderOffice[]> {
    const path = `v5/land/registration/recorder-offices`;

    return this.http.get<RecorderOffice[]>(path);
  }
Severity: Major
Found in src/app/data-services/recordable-subjects.data.service.ts and 7 other locations - About 1 hr to fix
src/app/data-services/_access-control.data.service.ts on lines 21..25
src/app/data-services/_access-control.data.service.ts on lines 28..32
src/app/data-services/recordable-subjects.data.service.ts on lines 96..100
src/app/data-services/transaction.data.service.ts on lines 22..26
src/app/data-services/transaction.data.service.ts on lines 29..33
src/app/data-services/transaction.data.service.ts on lines 45..49
src/app/data-services/transaction.data.service.ts on lines 52..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Invalid

  getRealEstateLotSizeUnits(): EmpObservable<Identifiable[]> {
    const path = `v5/land/registration/real-estate-lot-size-units`;

    return this.http.get<Identifiable[]>(path);
  }
Severity: Major
Found in src/app/data-services/recordable-subjects.data.service.ts and 7 other locations - About 1 hr to fix
src/app/data-services/_access-control.data.service.ts on lines 21..25
src/app/data-services/_access-control.data.service.ts on lines 28..32
src/app/data-services/recordable-subjects.data.service.ts on lines 103..107
src/app/data-services/transaction.data.service.ts on lines 22..26
src/app/data-services/transaction.data.service.ts on lines 29..33
src/app/data-services/transaction.data.service.ts on lines 45..49
src/app/data-services/transaction.data.service.ts on lines 52..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Invalid

  getAssociationKinds(): EmpObservable<string[]> {
    const path = `v5/land/registration/association-kinds`;

    return this.http.get<string[]>(path);
  }
Severity: Major
Found in src/app/data-services/recordable-subjects.data.service.ts and 3 other locations - About 55 mins to fix
src/app/data-services/recordable-subjects.data.service.ts on lines 66..70
src/app/data-services/recordable-subjects.data.service.ts on lines 82..86
src/app/data-services/recordable-subjects.data.service.ts on lines 89..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Invalid

  getRealEstateKinds(): EmpObservable<string[]> {
    const path = `v5/land/registration/real-estate-kinds`;

    return this.http.get<string[]>(path);
  }
Severity: Major
Found in src/app/data-services/recordable-subjects.data.service.ts and 3 other locations - About 55 mins to fix
src/app/data-services/recordable-subjects.data.service.ts on lines 59..63
src/app/data-services/recordable-subjects.data.service.ts on lines 66..70
src/app/data-services/recordable-subjects.data.service.ts on lines 89..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Invalid

  getNoPropertyKinds(): EmpObservable<string[]> {
    const path = `v5/land/registration/no-property-kinds`;

    return this.http.get<string[]>(path);
  }
Severity: Major
Found in src/app/data-services/recordable-subjects.data.service.ts and 3 other locations - About 55 mins to fix
src/app/data-services/recordable-subjects.data.service.ts on lines 59..63
src/app/data-services/recordable-subjects.data.service.ts on lines 82..86
src/app/data-services/recordable-subjects.data.service.ts on lines 89..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Invalid

  getRealEstatePartitionKinds(): EmpObservable<string[]> {
    const path = `v5/land/registration/real-estate-partition-kinds`;

    return this.http.get<string[]>(path);
  }
Severity: Major
Found in src/app/data-services/recordable-subjects.data.service.ts and 3 other locations - About 55 mins to fix
src/app/data-services/recordable-subjects.data.service.ts on lines 59..63
src/app/data-services/recordable-subjects.data.service.ts on lines 66..70
src/app/data-services/recordable-subjects.data.service.ts on lines 82..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status