Ontica/Empiria.Land.Intranet

View on GitHub
src/app/data-services/transaction.data.service.ts

Summary

Maintainability
A
2 hrs
Test Coverage

TransactionDataService has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

@Injectable()
export class TransactionDataService {

  constructor(private http: HttpService) { }

Severity: Minor
Found in src/app/data-services/transaction.data.service.ts - About 2 hrs to fix

    Similar blocks of code found in 8 locations. Consider refactoring.
    Invalid

      removeTransactionMediaFile(transactionUID: string, mediaFileUID: string): EmpObservable<PreprocessingData> {
        Assertion.assertValue(transactionUID, 'transactionUID');
        Assertion.assertValue(mediaFileUID, 'mediaFileUID');
    
        const path = `v5/land/transactions/${transactionUID}/media-files/${mediaFileUID}`;
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 7 other locations - About 3 hrs to fix
    src/app/data-services/certification.data.service.ts on lines 49..56
    src/app/data-services/certification.data.service.ts on lines 59..66
    src/app/data-services/recording.data.service.ts on lines 30..38
    src/app/data-services/recording.data.service.ts on lines 110..117
    src/app/data-services/recording.data.service.ts on lines 180..188
    src/app/data-services/recording.data.service.ts on lines 272..280
    src/app/data-services/transaction.data.service.ts on lines 152..160

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Invalid

      deleteTransactionService(transactionUID: string,
                               requestedServiceUID: string): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
        Assertion.assertValue(requestedServiceUID, 'requestedServiceUID');
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 7 other locations - About 3 hrs to fix
    src/app/data-services/certification.data.service.ts on lines 49..56
    src/app/data-services/certification.data.service.ts on lines 59..66
    src/app/data-services/recording.data.service.ts on lines 30..38
    src/app/data-services/recording.data.service.ts on lines 110..117
    src/app/data-services/recording.data.service.ts on lines 180..188
    src/app/data-services/recording.data.service.ts on lines 272..280
    src/app/data-services/transaction.data.service.ts on lines 241..248

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Invalid

      addTransactionService(transactionUID: string,
                            requestedService: RequestedServiceFields): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
        Assertion.assertValue(requestedService, 'requestedService');
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 10 other locations - About 2 hrs to fix
    src/app/data-services/_access-control.data.service.ts on lines 94..101
    src/app/data-services/certification.data.service.ts on lines 39..46
    src/app/data-services/recording.data.service.ts on lines 99..107
    src/app/data-services/recording.data.service.ts on lines 120..128
    src/app/data-services/recording.data.service.ts on lines 131..139
    src/app/data-services/recording.data.service.ts on lines 156..164
    src/app/data-services/recording.data.service.ts on lines 261..269
    src/app/data-services/recording.data.service.ts on lines 325..333
    src/app/data-services/transaction.data.service.ts on lines 194..201
    src/app/data-services/transaction.data.service.ts on lines 213..221

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Invalid

      updateTransaction(transactionUID: string,
                        transaction: TransactionFields): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
        Assertion.assertValue(transaction, 'transaction');
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 10 other locations - About 2 hrs to fix
    src/app/data-services/_access-control.data.service.ts on lines 94..101
    src/app/data-services/certification.data.service.ts on lines 39..46
    src/app/data-services/recording.data.service.ts on lines 99..107
    src/app/data-services/recording.data.service.ts on lines 120..128
    src/app/data-services/recording.data.service.ts on lines 131..139
    src/app/data-services/recording.data.service.ts on lines 156..164
    src/app/data-services/recording.data.service.ts on lines 261..269
    src/app/data-services/recording.data.service.ts on lines 325..333
    src/app/data-services/transaction.data.service.ts on lines 96..104
    src/app/data-services/transaction.data.service.ts on lines 194..201

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Invalid

      setPayment(transactionUID: string, payment: PaymentFields): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
        Assertion.assertValue(payment, 'payment');
    
        const path = `v5/land/transactions/${transactionUID}/set-payment`;
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 10 other locations - About 2 hrs to fix
    src/app/data-services/_access-control.data.service.ts on lines 94..101
    src/app/data-services/certification.data.service.ts on lines 39..46
    src/app/data-services/recording.data.service.ts on lines 99..107
    src/app/data-services/recording.data.service.ts on lines 120..128
    src/app/data-services/recording.data.service.ts on lines 131..139
    src/app/data-services/recording.data.service.ts on lines 156..164
    src/app/data-services/recording.data.service.ts on lines 261..269
    src/app/data-services/recording.data.service.ts on lines 325..333
    src/app/data-services/transaction.data.service.ts on lines 96..104
    src/app/data-services/transaction.data.service.ts on lines 213..221

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Invalid

      getTransaction(transactionUID: string): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
    
        const path = `v5/land/transactions/${transactionUID}`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 17 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 122..128
    src/app/data-services/_access-control.data.service.ts on lines 131..137
    src/app/data-services/recordable-subjects.data.service.ts on lines 133..139
    src/app/data-services/recording.data.service.ts on lines 81..87
    src/app/data-services/recording.data.service.ts on lines 90..96
    src/app/data-services/recording.data.service.ts on lines 297..303
    src/app/data-services/recording.data.service.ts on lines 306..312
    src/app/data-services/recording.data.service.ts on lines 348..354
    src/app/data-services/recording.data.service.ts on lines 357..363
    src/app/data-services/transaction.data.service.ts on lines 59..65
    src/app/data-services/transaction.data.service.ts on lines 87..93
    src/app/data-services/transaction.data.service.ts on lines 107..113
    src/app/data-services/transaction.data.service.ts on lines 116..122
    src/app/data-services/transaction.data.service.ts on lines 125..131
    src/app/data-services/transaction.data.service.ts on lines 143..149
    src/app/data-services/transaction.data.service.ts on lines 176..182
    src/app/data-services/transaction.data.service.ts on lines 204..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Invalid

      deleteTransaction(transactionUID: string): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
    
        const path = `v5/land/transactions/${transactionUID}`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 17 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 122..128
    src/app/data-services/_access-control.data.service.ts on lines 131..137
    src/app/data-services/recordable-subjects.data.service.ts on lines 133..139
    src/app/data-services/recording.data.service.ts on lines 81..87
    src/app/data-services/recording.data.service.ts on lines 90..96
    src/app/data-services/recording.data.service.ts on lines 297..303
    src/app/data-services/recording.data.service.ts on lines 306..312
    src/app/data-services/recording.data.service.ts on lines 348..354
    src/app/data-services/recording.data.service.ts on lines 357..363
    src/app/data-services/transaction.data.service.ts on lines 59..65
    src/app/data-services/transaction.data.service.ts on lines 68..74
    src/app/data-services/transaction.data.service.ts on lines 87..93
    src/app/data-services/transaction.data.service.ts on lines 107..113
    src/app/data-services/transaction.data.service.ts on lines 116..122
    src/app/data-services/transaction.data.service.ts on lines 125..131
    src/app/data-services/transaction.data.service.ts on lines 176..182
    src/app/data-services/transaction.data.service.ts on lines 204..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Invalid

      getTransactionPreprocessingData(transactionUID: string): EmpObservable<PreprocessingData> {
        Assertion.assertValue(transactionUID, 'transactionUID');
    
        const path = `v5/land/transactions/${transactionUID}/preprocessing-data`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 17 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 122..128
    src/app/data-services/_access-control.data.service.ts on lines 131..137
    src/app/data-services/recordable-subjects.data.service.ts on lines 133..139
    src/app/data-services/recording.data.service.ts on lines 81..87
    src/app/data-services/recording.data.service.ts on lines 90..96
    src/app/data-services/recording.data.service.ts on lines 297..303
    src/app/data-services/recording.data.service.ts on lines 306..312
    src/app/data-services/recording.data.service.ts on lines 348..354
    src/app/data-services/recording.data.service.ts on lines 357..363
    src/app/data-services/transaction.data.service.ts on lines 68..74
    src/app/data-services/transaction.data.service.ts on lines 87..93
    src/app/data-services/transaction.data.service.ts on lines 107..113
    src/app/data-services/transaction.data.service.ts on lines 116..122
    src/app/data-services/transaction.data.service.ts on lines 125..131
    src/app/data-services/transaction.data.service.ts on lines 143..149
    src/app/data-services/transaction.data.service.ts on lines 176..182
    src/app/data-services/transaction.data.service.ts on lines 204..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Invalid

      getWorkflowHistoryForTransaction(transactionUID: string): EmpObservable<WorkflowTask> {
        Assertion.assertValue(transactionUID, 'transactionUID');
    
        const path = `v5/land/workflow/${transactionUID}/history`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 17 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 122..128
    src/app/data-services/_access-control.data.service.ts on lines 131..137
    src/app/data-services/recordable-subjects.data.service.ts on lines 133..139
    src/app/data-services/recording.data.service.ts on lines 81..87
    src/app/data-services/recording.data.service.ts on lines 90..96
    src/app/data-services/recording.data.service.ts on lines 297..303
    src/app/data-services/recording.data.service.ts on lines 306..312
    src/app/data-services/recording.data.service.ts on lines 348..354
    src/app/data-services/recording.data.service.ts on lines 357..363
    src/app/data-services/transaction.data.service.ts on lines 59..65
    src/app/data-services/transaction.data.service.ts on lines 68..74
    src/app/data-services/transaction.data.service.ts on lines 107..113
    src/app/data-services/transaction.data.service.ts on lines 116..122
    src/app/data-services/transaction.data.service.ts on lines 125..131
    src/app/data-services/transaction.data.service.ts on lines 143..149
    src/app/data-services/transaction.data.service.ts on lines 176..182
    src/app/data-services/transaction.data.service.ts on lines 204..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Invalid

      cancelPaymentOrder(transactionUID: string): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
    
        const path = `v5/land/transactions/${transactionUID}/cancel-payment-order`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 17 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 122..128
    src/app/data-services/_access-control.data.service.ts on lines 131..137
    src/app/data-services/recordable-subjects.data.service.ts on lines 133..139
    src/app/data-services/recording.data.service.ts on lines 81..87
    src/app/data-services/recording.data.service.ts on lines 90..96
    src/app/data-services/recording.data.service.ts on lines 297..303
    src/app/data-services/recording.data.service.ts on lines 306..312
    src/app/data-services/recording.data.service.ts on lines 348..354
    src/app/data-services/recording.data.service.ts on lines 357..363
    src/app/data-services/transaction.data.service.ts on lines 59..65
    src/app/data-services/transaction.data.service.ts on lines 68..74
    src/app/data-services/transaction.data.service.ts on lines 87..93
    src/app/data-services/transaction.data.service.ts on lines 107..113
    src/app/data-services/transaction.data.service.ts on lines 125..131
    src/app/data-services/transaction.data.service.ts on lines 143..149
    src/app/data-services/transaction.data.service.ts on lines 176..182
    src/app/data-services/transaction.data.service.ts on lines 204..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Invalid

      cloneTransaction(transactionUID: string): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
    
        const path = `v5/land/transactions/${transactionUID}/clone`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 17 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 122..128
    src/app/data-services/_access-control.data.service.ts on lines 131..137
    src/app/data-services/recordable-subjects.data.service.ts on lines 133..139
    src/app/data-services/recording.data.service.ts on lines 81..87
    src/app/data-services/recording.data.service.ts on lines 90..96
    src/app/data-services/recording.data.service.ts on lines 297..303
    src/app/data-services/recording.data.service.ts on lines 306..312
    src/app/data-services/recording.data.service.ts on lines 348..354
    src/app/data-services/recording.data.service.ts on lines 357..363
    src/app/data-services/transaction.data.service.ts on lines 59..65
    src/app/data-services/transaction.data.service.ts on lines 68..74
    src/app/data-services/transaction.data.service.ts on lines 87..93
    src/app/data-services/transaction.data.service.ts on lines 107..113
    src/app/data-services/transaction.data.service.ts on lines 116..122
    src/app/data-services/transaction.data.service.ts on lines 143..149
    src/app/data-services/transaction.data.service.ts on lines 176..182
    src/app/data-services/transaction.data.service.ts on lines 204..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Invalid

      cancelPayment(transactionUID: string): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
    
        const path = `v5/land/transactions/${transactionUID}/cancel-payment`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 17 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 122..128
    src/app/data-services/_access-control.data.service.ts on lines 131..137
    src/app/data-services/recordable-subjects.data.service.ts on lines 133..139
    src/app/data-services/recording.data.service.ts on lines 81..87
    src/app/data-services/recording.data.service.ts on lines 90..96
    src/app/data-services/recording.data.service.ts on lines 297..303
    src/app/data-services/recording.data.service.ts on lines 306..312
    src/app/data-services/recording.data.service.ts on lines 348..354
    src/app/data-services/recording.data.service.ts on lines 357..363
    src/app/data-services/transaction.data.service.ts on lines 59..65
    src/app/data-services/transaction.data.service.ts on lines 68..74
    src/app/data-services/transaction.data.service.ts on lines 87..93
    src/app/data-services/transaction.data.service.ts on lines 116..122
    src/app/data-services/transaction.data.service.ts on lines 125..131
    src/app/data-services/transaction.data.service.ts on lines 143..149
    src/app/data-services/transaction.data.service.ts on lines 176..182
    src/app/data-services/transaction.data.service.ts on lines 204..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Invalid

      generatePaymentOrder(transactionUID: string): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
    
        const path = `v5/land/transactions/${transactionUID}/generate-payment-order`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 17 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 122..128
    src/app/data-services/_access-control.data.service.ts on lines 131..137
    src/app/data-services/recordable-subjects.data.service.ts on lines 133..139
    src/app/data-services/recording.data.service.ts on lines 81..87
    src/app/data-services/recording.data.service.ts on lines 90..96
    src/app/data-services/recording.data.service.ts on lines 297..303
    src/app/data-services/recording.data.service.ts on lines 306..312
    src/app/data-services/recording.data.service.ts on lines 348..354
    src/app/data-services/recording.data.service.ts on lines 357..363
    src/app/data-services/transaction.data.service.ts on lines 59..65
    src/app/data-services/transaction.data.service.ts on lines 68..74
    src/app/data-services/transaction.data.service.ts on lines 87..93
    src/app/data-services/transaction.data.service.ts on lines 107..113
    src/app/data-services/transaction.data.service.ts on lines 116..122
    src/app/data-services/transaction.data.service.ts on lines 125..131
    src/app/data-services/transaction.data.service.ts on lines 143..149
    src/app/data-services/transaction.data.service.ts on lines 204..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Invalid

      submitTransaction(transactionUID: string): EmpObservable<Transaction> {
        Assertion.assertValue(transactionUID, 'transactionUID');
    
        const path = `v5/land/transactions/${transactionUID}/submit`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 17 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 122..128
    src/app/data-services/_access-control.data.service.ts on lines 131..137
    src/app/data-services/recordable-subjects.data.service.ts on lines 133..139
    src/app/data-services/recording.data.service.ts on lines 81..87
    src/app/data-services/recording.data.service.ts on lines 90..96
    src/app/data-services/recording.data.service.ts on lines 297..303
    src/app/data-services/recording.data.service.ts on lines 306..312
    src/app/data-services/recording.data.service.ts on lines 348..354
    src/app/data-services/recording.data.service.ts on lines 357..363
    src/app/data-services/transaction.data.service.ts on lines 59..65
    src/app/data-services/transaction.data.service.ts on lines 68..74
    src/app/data-services/transaction.data.service.ts on lines 87..93
    src/app/data-services/transaction.data.service.ts on lines 107..113
    src/app/data-services/transaction.data.service.ts on lines 116..122
    src/app/data-services/transaction.data.service.ts on lines 125..131
    src/app/data-services/transaction.data.service.ts on lines 143..149
    src/app/data-services/transaction.data.service.ts on lines 176..182

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Invalid

      createTransaction(transaction: TransactionFields): EmpObservable<Transaction> {
        Assertion.assertValue(transaction, 'transaction');
    
        const path = `v5/land/transactions`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 2 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 85..91
    src/app/data-services/transaction.data.service.ts on lines 185..191

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Invalid

      searchAndAssertCommandExecution(command: WorkflowCommand): EmpObservable<TransactionDescriptor> {
        Assertion.assertValue(command, 'command');
    
        const path = `v5/land/workflow/search-and-assert-command-execution`;
    
    
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 2 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 85..91
    src/app/data-services/transaction.data.service.ts on lines 134..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Invalid

      getAgencies(): EmpObservable<Agency[]> {
        const path = `v5/land/agencies`;
    
        return this.http.get<Agency[]>(path);
      }
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 7 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 21..25
    src/app/data-services/_access-control.data.service.ts on lines 28..32
    src/app/data-services/recordable-subjects.data.service.ts on lines 96..100
    src/app/data-services/recordable-subjects.data.service.ts on lines 103..107
    src/app/data-services/transaction.data.service.ts on lines 29..33
    src/app/data-services/transaction.data.service.ts on lines 45..49
    src/app/data-services/transaction.data.service.ts on lines 52..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Invalid

      getTransactionTypes(): EmpObservable<TransactionType[]> {
        const path = `v5/land/transaction-types`;
    
        return this.http.get<TransactionType[]>(path);
      }
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 7 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 21..25
    src/app/data-services/_access-control.data.service.ts on lines 28..32
    src/app/data-services/recordable-subjects.data.service.ts on lines 96..100
    src/app/data-services/recordable-subjects.data.service.ts on lines 103..107
    src/app/data-services/transaction.data.service.ts on lines 22..26
    src/app/data-services/transaction.data.service.ts on lines 29..33
    src/app/data-services/transaction.data.service.ts on lines 45..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Invalid

      getAllAvailableCommandTypes(): EmpObservable<ApplicableCommand[]> {
        const path = `v5/land/workflow/all-command-types`;
    
        return this.http.get<ApplicableCommand[]>(path);
      }
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 7 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 21..25
    src/app/data-services/_access-control.data.service.ts on lines 28..32
    src/app/data-services/recordable-subjects.data.service.ts on lines 96..100
    src/app/data-services/recordable-subjects.data.service.ts on lines 103..107
    src/app/data-services/transaction.data.service.ts on lines 22..26
    src/app/data-services/transaction.data.service.ts on lines 45..49
    src/app/data-services/transaction.data.service.ts on lines 52..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Invalid

      getProvidedServices(): EmpObservable<ProvidedServiceType[]> {
        const path = `v5/land/provided-services`;
    
        return this.http.get<ProvidedServiceType[]>(path);
      }
    Severity: Major
    Found in src/app/data-services/transaction.data.service.ts and 7 other locations - About 1 hr to fix
    src/app/data-services/_access-control.data.service.ts on lines 21..25
    src/app/data-services/_access-control.data.service.ts on lines 28..32
    src/app/data-services/recordable-subjects.data.service.ts on lines 96..100
    src/app/data-services/recordable-subjects.data.service.ts on lines 103..107
    src/app/data-services/transaction.data.service.ts on lines 22..26
    src/app/data-services/transaction.data.service.ts on lines 29..33
    src/app/data-services/transaction.data.service.ts on lines 52..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status