Ontica/Empiria.Land.Intranet

View on GitHub
src/app/presentation/land/recordable-subjects.presentation.handler.ts

Summary

Maintainability
C
1 day
Test Coverage

Function select has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  select<U>(selectorType: SelectorType, params?: any): EmpObservable<U> {
    let provider: () => any;

    switch (selectorType) {

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          case SelectorType.AMENDABLE_RECORDING_ACTS:
            Assertion.assertValue(params.query, 'params.query');
    
            return this.data.getAmendableRecordingActs(params.query) as EmpObservable<U>;
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 137..140
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 142..145
    src/app/presentation/land/registration.presentation.handler.ts on lines 100..103
    src/app/presentation/land/registration.presentation.handler.ts on lines 105..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          case SelectorType.TRACT_INDEX:
            Assertion.assertValue(params.recordableSubjectUID, 'params.recordableSubjectUID');
    
            return this.data.getFullTractIndex(params.recordableSubjectUID) as EmpObservable<U>;
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 71..74
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 137..140
    src/app/presentation/land/registration.presentation.handler.ts on lines 100..103
    src/app/presentation/land/registration.presentation.handler.ts on lines 105..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          case SelectorType.RECORDING_BOOK_ENTRIES_LIST:
            Assertion.assertValue(params.recordingBookUID, 'params.recordingBookUID');
    
            return this.data.getRecordingBookEntries(params.recordingBookUID) as EmpObservable<U>;
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 71..74
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 142..145
    src/app/presentation/land/registration.presentation.handler.ts on lines 100..103
    src/app/presentation/land/registration.presentation.handler.ts on lines 105..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

          case SelectorType.REAL_ESTATE_KIND_LIST:
            provider = () => this.data.getRealEstateKinds();
    
            return super.selectFirst<U>(selectorType, provider);
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 77..80
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 99..102
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 111..114
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 117..120
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 123..126
    src/app/presentation/land/transaction.presentation.handler.ts on lines 124..127
    src/app/presentation/land/transaction.presentation.handler.ts on lines 129..132
    src/app/presentation/land/transaction.presentation.handler.ts on lines 134..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

          case SelectorType.ASSOCIATION_KIND_LIST:
            provider = () => this.data.getAssociationKinds();
    
            return super.selectFirst<U>(selectorType, provider);
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 99..102
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 105..108
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 111..114
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 117..120
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 123..126
    src/app/presentation/land/transaction.presentation.handler.ts on lines 124..127
    src/app/presentation/land/transaction.presentation.handler.ts on lines 129..132
    src/app/presentation/land/transaction.presentation.handler.ts on lines 134..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

          case SelectorType.NO_PROPERTY_KIND_LIST:
            provider = () => this.data.getNoPropertyKinds();
    
            return super.selectFirst<U>(selectorType, provider);
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 77..80
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 105..108
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 111..114
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 117..120
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 123..126
    src/app/presentation/land/transaction.presentation.handler.ts on lines 124..127
    src/app/presentation/land/transaction.presentation.handler.ts on lines 129..132
    src/app/presentation/land/transaction.presentation.handler.ts on lines 134..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

          case SelectorType.REAL_ESTATE_PARTITION_KIND_LIST:
            provider = () => this.data.getRealEstatePartitionKinds();
    
            return super.selectFirst<U>(selectorType, provider);
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 77..80
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 99..102
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 105..108
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 117..120
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 123..126
    src/app/presentation/land/transaction.presentation.handler.ts on lines 124..127
    src/app/presentation/land/transaction.presentation.handler.ts on lines 129..132
    src/app/presentation/land/transaction.presentation.handler.ts on lines 134..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

          case SelectorType.REAL_ESTATE_LOT_SIZE_UNIT_LIST:
            provider = () => this.data.getRealEstateLotSizeUnits();
    
            return super.selectFirst<U>(selectorType, provider);
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 77..80
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 99..102
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 105..108
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 111..114
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 123..126
    src/app/presentation/land/transaction.presentation.handler.ts on lines 124..127
    src/app/presentation/land/transaction.presentation.handler.ts on lines 129..132
    src/app/presentation/land/transaction.presentation.handler.ts on lines 134..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

          case SelectorType.RECORDER_OFFICE_LIST:
            provider = () => this.data.getRecorderOffices();
    
            return super.selectFirst<U>(selectorType, provider);
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 77..80
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 99..102
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 105..108
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 111..114
    src/app/presentation/land/recordable-subjects.presentation.handler.ts on lines 117..120
    src/app/presentation/land/transaction.presentation.handler.ts on lines 124..127
    src/app/presentation/land/transaction.presentation.handler.ts on lines 129..132
    src/app/presentation/land/transaction.presentation.handler.ts on lines 134..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status