Sign upLogin

OpServ-Monitoring/opserv-backend

View on GitHub
Star
app/gathering/gatherer_manager.py

Summary

Maintainability
A
1 hr
Test Coverage

Function request_valid has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def request_valid(request):
    """
        Checks the given request for the correct data structure
        Returns True if it has the right structure
    """
Severity: Minor
Found in app/gathering/gatherer_manager.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function rate_update_valid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def rate_update_valid(rate_update):
    """
        Checks the given rate_update for the correct data structure
        Returns True if it has the right structure
    """
Severity: Minor
Found in app/gathering/gatherer_manager.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status