Sign upLogin

OpServ-Monitoring/opserv-backend

View on GitHub
Star
app/gathering/measuring/ohm_source.py

Summary

Maintainability
C
1 day
Test Coverage

File ohm_source.py has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'''
    This module is pretty experimental and uses pythonnet to laod a C#-DLL
    The OpenHardwareMonitorLib is a pretty sophisticated library to get system metrics
    For more information about the project/code visit the GitHub Repository
    https://github.com/openhardwaremonitor/openhardwaremonitor
Severity: Minor
Found in app/gathering/measuring/ohm_source.py - About 3 hrs to fix

    Function add_cpu has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def add_cpu(self, hardware):
        '''
            Adds the given CPU (as OHM Hardware Object) to the cpu list
            Also adds all its cores and updates the supported metrics
        '''
    Severity: Minor
    Found in app/gathering/measuring/ohm_source.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_measurement has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_measurement(self, component, metric, args):
        '''
            Retrieves a measurement from the measuring source
            given the component, metric and optionally arguments
        '''
    Severity: Minor
    Found in app/gathering/measuring/ohm_source.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_cpu_measurement has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_cpu_measurement(self, metric, args):
        """
            Updates the hardware class for the specified cpu (not cores, whole cpu socket)
            and returns the value for the  specified metric
        """
    Severity: Minor
    Found in app/gathering/measuring/ohm_source.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_core_measurement has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_core_measurement(self, metric, args):
        """
            Updates the hardware of the given cpu core to get a measurement
            for the specified metric
        """
    Severity: Minor
    Found in app/gathering/measuring/ohm_source.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ohm_hardware_added_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def ohm_hardware_added_handler(self, hardware):
        """
            Hardware Added Handler
            This is called with the given hardware when a new hardware on the computer is found
        """
    Severity: Minor
    Found in app/gathering/measuring/ohm_source.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            elif component == "memory":
            result = self.get_memory_measurement(metric)
        elif component == "disk":
            result = self.get_disk_measurement(metric, args)
        elif component == "system":
    Severity: Major
    Found in app/gathering/measuring/ohm_source.py and 1 other location - About 1 hr to fix
    app/gathering/measuring/psutil_source.py on lines 144..150

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status