OpenC3/cosmos

Avoid deeply nested control flow statements.

Open

          unless @out_of_order
            Logger.error("Log writer out of order time detected (increase buffer depth?): #{Time.from_nsec_from_epoch(@previous_time_nsec_since_epoch)} #{Time.from_nsec_from_epoch(time_nsec_since_epoch)}")
            @out_of_order = true
          end

Avoid deeply nested control flow statements.

Open

            if endianness == :LITTLE_ENDIAN
              # Bitoffset always refers to the most significant bit of a bitfield
              num_bytes = (((bit_offset % 8) + bit_size - 1) / 8) + 1
              upper_bound = bit_offset / 8
              lower_bound = upper_bound - num_bytes + 1

Avoid deeply nested control flow statements.

Open

          if byte_aligned(bit_offset)
            case bit_size
            when 32
              if endianness == :BIG_ENDIAN
                buffer[lower_bound..upper_bound] = [value].pack(PACK_BIG_ENDIAN_32_BIT_FLOAT)

Avoid deeply nested control flow statements.

Open

                if plugin_instance
                  if old_plugin_name
                    # And we're updating a plugin
                    data = File.read(plugin_instance)
                    json = JSON.parse(data, :allow_nan => true, :create_additions => true)

Avoid deeply nested control flow statements.

Open

                if input == 'REJECTED'
                  raise "Critical Cmd Rejected"
                end

Avoid deeply nested control flow statements.

Open

              if packet_objects.length == 0
                # Nothing left in either for this topic
                @topics_and_offsets.delete(object.topic)
              end

Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

      dest_address,
      dest_port,
      src_port = nil,
      multicast_interface_address = nil,
      ttl = 1,

Avoid deeply nested control flow statements.

Open

                if parsed_cmd["password"]
                  running_script.user_input = parsed_cmd["password"].to_s
                elsif parsed_cmd["multiple"]
                  running_script.user_input = JSON.parse(parsed_cmd["multiple"])
                  run_script_log(id, "Multiple input: #{running_script.user_input}")

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    when :Z, :z, 3
      rotation_matrix[0][0] = cos(rotation_angle_in_radians)
      rotation_matrix[0][1] = sin(rotation_angle_in_radians)
      rotation_matrix[1][1] = rotation_matrix[0][0]
      rotation_matrix[1][0] = -(rotation_matrix[0][1])

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      } else if (chunkType === C.DIFF_INSERT) {
        diffs.push(
          computeDiff(this, C.DIFF_INSERT, offset.left, offset.right, text),
        )
        offset.left += text.length

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      } else if (chunkType === C.DIFF_DELETE) {
        diffs.push(
          computeDiff(this, C.DIFF_DELETE, offset.left, offset.right, text),
        )
        offset.right += text.length

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    when :X, :x, 1
      rotation_matrix[1][1] = cos(rotation_angle_in_radians)
      rotation_matrix[1][2] = sin(rotation_angle_in_radians)
      rotation_matrix[2][2] = rotation_matrix[1][1]
      rotation_matrix[2][1] = -(rotation_matrix[1][2])

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      if hash['read_conversion']
        begin
          item.read_conversion = OpenC3::const_get(hash['read_conversion']['class']).new(*hash['read_conversion']['params'])
        rescue => error
          Logger.instance.error "#{item.name} read_conversion of #{hash['read_conversion']} could not be instantiated due to #{error}"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def self.connect_interface(interface_name, *interface_params, scope:)
      if interface_params && !interface_params.empty?
        Topic.write_topic("{#{scope}__CMD}INTERFACE__#{interface_name}", { 'connect' => 'true', 'params' => JSON.generate(interface_params) }, '*', 100)
      else
        Topic.write_topic("{#{scope}__CMD}INTERFACE__#{interface_name}", { 'connect' => 'true' }, '*', 100)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  def add(data)
    if validate_data(data)
      begin
        @broadcasters[uuid].add(data)
      rescue OpenC3::AuthError, OpenC3::ForbiddenError

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      new OpenC3Api()
        .load_config(this.configKey, name)
        .then((response) => {
          if (response) {
            this.$notify.normal({

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    when :Y, :y, 2
      rotation_matrix[0][0] = cos(rotation_angle_in_radians)
      rotation_matrix[2][0] = sin(rotation_angle_in_radians)
      rotation_matrix[2][2] = rotation_matrix[0][0]
      rotation_matrix[0][2] = -(rotation_matrix[2][0])

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  def remove(data)
    if validate_data(data)
      begin
        @broadcasters[uuid].remove(data)
      rescue OpenC3::AuthError, OpenC3::ForbiddenError

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def self.connect_router(router_name, *router_params, scope:)
      if router_params && !router_params.empty?
        Topic.write_topic("{#{scope}__CMD}ROUTER__#{router_name}", { 'connect' => 'true', 'params' => JSON.generate(router_params) }, '*', 100)
      else
        Topic.write_topic("{#{scope}__CMD}ROUTER__#{router_name}", { 'connect' => 'true' }, '*', 100)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      new OpenC3Api()
        .save_config(this.configKey, name, JSON.stringify(config))
        .then(() => {
          this.$notify.normal({
            title: 'Saved configuration',

• Read up
  Read up