OpenC3/cosmos

View on GitHub
openc3-cosmos-script-runner-api/app/models/script.rb

Summary

Maintainability
C
1 day
Test Coverage

Method process_suite has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.process_suite(name, contents, new_process: true, username: nil, scope:)
    python = false
    python = true if File.extname(name) == '.py'

    start = Time.now
Severity: Major
Found in openc3-cosmos-script-runner-api/app/models/script.rb - About 3 hrs to fix

    Method syntax has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.syntax(filename, text)
        language = detect_language(text, filename)
        if language == 'ruby'
          check_process = IO.popen('ruby -c -rubygems 2>&1', 'r+')
          check_process.write("require 'openc3'; require 'openc3/script'; " + text)
    Severity: Major
    Found in openc3-cosmos-script-runner-api/app/models/script.rb - About 2 hrs to fix

      Method instrumented has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.instrumented(filename, text)
          language = detect_language(text, filename)
          if language == 'ruby'
            return {
              'title' => 'Instrumented Script',
      Severity: Major
      Found in openc3-cosmos-script-runner-api/app/models/script.rb - About 2 hrs to fix

        Method run has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            scope,
            name,
            suite_runner = nil,
            disconnect = false,
            environment = nil,
        Severity: Major
        Found in openc3-cosmos-script-runner-api/app/models/script.rb - About 50 mins to fix

          Avoid too many return statements within this method.
          Open

              return 'python' if text =~ /^\s*(if|def|while|else|elif|class).*:\s*$/
          Severity: Major
          Found in openc3-cosmos-script-runner-api/app/models/script.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return(
                        {
                          'title' => 'Syntax Check Successful',
                          'description' => ["Syntax OK"].as_json(:allow_nan => true).to_json(:allow_nan => true),
                        }
            Severity: Major
            Found in openc3-cosmos-script-runner-api/app/models/script.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return 'ruby' if text =~ /^\s*end\s*$/
              Severity: Major
              Found in openc3-cosmos-script-runner-api/app/models/script.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return 'ruby' # otherwise guess Ruby
                Severity: Major
                Found in openc3-cosmos-script-runner-api/app/models/script.rb - About 30 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          auth = OpenC3::OpenC3KeycloakAuthentication.new(ENV['OPENC3_KEYCLOAK_URL'])
                          valid_token = auth.get_token_from_refresh_token(model.offline_access_token)
                          if valid_token
                            process.environment['OPENC3_API_TOKEN'] = model.offline_access_token
                          else
                  Severity: Minor
                  Found in openc3-cosmos-script-runner-api/app/models/script.rb and 1 other location - About 25 mins to fix
                  openc3-cosmos-script-runner-api/app/models/running_script.rb on lines 357..364

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 29.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status