Sign upLogin

OpenC3/cosmos

View on GitHub
Star
openc3/lib/openc3/interfaces/simulated_target_interface.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method read has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def read
      packet = nil
      if @connected
        while true
          packet = first_pending_packet()
Severity: Minor
Found in openc3/lib/openc3/interfaces/simulated_target_interface.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return packet
    Severity: Major
    Found in openc3/lib/openc3/interfaces/simulated_target_interface.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return packet
      Severity: Major
      Found in openc3/lib/openc3/interfaces/simulated_target_interface.rb - About 30 mins to fix

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                    @read_protocols.each do |protocol|
              packet = protocol.read_packet(packet)
              if packet == :DISCONNECT
                Logger.info("#{@name}: Protocol #{protocol.class} read_packet requested disconnect")
                return nil
        Severity: Minor
        Found in openc3/lib/openc3/interfaces/simulated_target_interface.rb and 2 other locations - About 25 mins to fix
        openc3/lib/openc3/interfaces/interface.rb on lines 299..305
        openc3/lib/openc3/interfaces/simulated_target_interface.rb on lines 79..85

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                  @read_protocols.each do |protocol|
            packet = protocol.read_packet(packet)
            if packet == :DISCONNECT
              Logger.info("#{@name}: Protocol #{protocol.class} read_packet requested disconnect")
              return nil
        Severity: Minor
        Found in openc3/lib/openc3/interfaces/simulated_target_interface.rb and 2 other locations - About 25 mins to fix
        openc3/lib/openc3/interfaces/interface.rb on lines 299..305
        openc3/lib/openc3/interfaces/simulated_target_interface.rb on lines 110..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status