Sign upLogin

OpenC3/cosmos

View on GitHub
Star
openc3/lib/openc3/models/activity_model.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method create has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def create(overlap: true)
      if @recurring['end'] and @recurring['frequency'] and @recurring['span']
        # First validate the initial recurring activity ... all others are just offsets
        validate_input(start: @start, stop: @stop, kind: @kind, data: @data)
Severity: Major
Found in openc3/lib/openc3/models/activity_model.rb - About 2 hrs to fix

    Method destroy has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.destroy(name:, scope:, score:, uuid: nil, recurring: nil)
      result = 0

      # Delete all recurring activities
      if recurring
    Severity: Minor
    Found in openc3/lib/openc3/models/activity_model.rb - About 1 hr to fix

      Method update has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def update(start:, stop:, kind:, data:, overlap: true)
      array = Store.zrangebyscore(@primary_key, @start, @start)
      if array.length == 0
        raise ActivityError.new "failed to find activity at: #{@start}"
      end
      Severity: Minor
      Found in openc3/lib/openc3/models/activity_model.rb - About 1 hr to fix

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

            def self.from_json(json, name:, scope:)
      json = JSON.parse(json, :allow_nan => true, :create_additions => true) if String === json
      raise "json data is nil" if json.nil?
      self.new(**json.transform_keys(&:to_sym), name: name, scope: scope)
        Severity: Major
        Found in openc3/lib/openc3/models/activity_model.rb and 4 other locations - About 35 mins to fix
        openc3/lib/openc3/models/reaction_model.rb on lines 271..274
        openc3/lib/openc3/models/timeline_model.rb on lines 71..74
        openc3/lib/openc3/models/trigger_group_model.rb on lines 101..104
        openc3/lib/openc3/models/trigger_model.rb on lines 280..283

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status