OpenC3/cosmos

Method read has 80 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def read(name, value_type = :CONVERTED, reduced_type = nil)
      value = nil
      array_index = nil
      # Check for array index to handle array items but also make sure there
      # isn't a REAL item that has brackets in the name

Method read_all_names has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def read_all_names(value_type = nil, reduced_type = nil)
      result = {}
      if value_type
        case value_type
        when :RAW

Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def initialize(cmd_or_tlm, target_name, packet_name, time_nsec_since_epoch, stored, json_data, key_map = nil, received_time_nsec_since_epoch: nil, extra: nil)

Avoid too many return statements within this method.

Open

          return value.to_s

Avoid too many return statements within this method.

Open

          return value.to_s

Avoid too many return statements within this method.

Open

          return value

Avoid too many return statements within this method.

Open

        return nil

Avoid too many return statements within this method.

Open

        return value

Avoid too many return statements within this method.

Open

      return nil

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        case reduced_type
        when :AVG
          value = @json_hash["#{name}__A"]
        when :STDDEV
          value = @json_hash["#{name}__S"]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          case reduced_type
          when :AVG
            value = @json_hash["#{name}__CA"]
          when :STDDEV
            value = @json_hash["#{name}__CS"]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def read_all(value_type = :CONVERTED, reduced_type = nil, names = nil)
      result = {}
      names = read_all_names() unless names
      names.each do |name|
        result[name] = read(name, value_type, reduced_type)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def read_all_with_limits_states(value_type = :CONVERTED, reduced_type = nil, names = nil)
      result = {}
      names = read_all_names() unless names
      names.each do |name|
        result[name] = read_with_limits_state(name, value_type, reduced_type)

• Read up
  Read up